Skip to content

Added Arc Browser Support (#32782)#34505

Closed
TheRedDeveloper wants to merge 3 commits into
microsoft:mainfrom
TheRedDeveloper:ArcFix
Closed

Added Arc Browser Support (#32782)#34505
TheRedDeveloper wants to merge 3 commits into
microsoft:mainfrom
TheRedDeveloper:ArcFix

Conversation

@TheRedDeveloper
Copy link
Copy Markdown

Arc.exe doesn't take parameters. You have to call url.dll instead.
I was unable to test this code, as I've tried for 4 hours now to get PowerToys Run working at all.
You know something is wrong, when the "stable" branch doesn't even build when following the Dev Documentation.
Eighter it's a "my machine" problem or everything is just broken right now.
Anyway, this small change will eliminate the problem (#32782), if I could even get to it.
Feel free to change whatever, I just want it to work with Arc.

TheRedDeveloper and others added 2 commits August 30, 2024 23:42
* [Workspaces] re-implementing hotkey handling

* [Workspaces] fix interop reference

* Reimplement message sending

* cleanup

* Do not recreate event

* bring back minimized logic

---------

Co-authored-by: Stefan Markovic <stefan@janeasystems.com>
Comment thread src/modules/launcher/Wox.Plugin/Common/DefaultBrowserInfo.cs Outdated
@htcfreek
Copy link
Copy Markdown
Collaborator

I was unable to test this code, as I've tried for 4 hours now to get PowerToys Run working at all.
You know something is wrong, when the "stable" branch doesn't even build when following the Dev Documentation.

@TheRedDeveloper
I left a code comment. Normally you have to clone the repo, then do git submodule update --init --recursive and then you can set the PowerLauncher project as startup project and run a debug build.

@TheRedDeveloper
Copy link
Copy Markdown
Author

@htcfreek I fixed it and did all the things you told me to do. It's still not building for me.
The type or namespace name 'PowerToys' could not be found in the global namespace (are you missing an assembly reference?)

@htcfreek
Copy link
Copy Markdown
Collaborator

htcfreek commented Aug 31, 2024

@htcfreek I fixed it and did all the things you told me to do. It's still not building for me. The type or namespace name 'PowerToys' could not be found in the global namespace (are you missing an assembly reference?)

@TheRedDeveloper
Ads the CI now builds without errors this sound like a local code problem. You can try to clean the data from your failed build commands by executing git clean -xfd. (VS should be closed.) Then you can execute git submodule update --init --recursive, open the solution in VS, set the PowerLauncher project as startup project and run a debug build.

@TheRedDeveloper
Copy link
Copy Markdown
Author

TheRedDeveloper commented Aug 31, 2024

It appears to me like this shouldn't work, because it somehow runs rundll32 url.dll,FileProtocolHandler ? some search

@TheRedDeveloper
Copy link
Copy Markdown
Author

I fixed this for me by creating this .bat and changing the opening command for Arc in the registry to it.

@echo off
setlocal enabledelayedexpansion
set "input=%*"
if "%input:~0,1%"=="?" (
    set "search=%input:~2%"
    if /i "!search:~0,4!"=="http" (
        set "url=!search!"
    ) else (
        set "url=https://www.google.com/search?q=!search: =+!"
    )
) else (
    set "url=%input%"
)
C:\Windows\System32\rundll32.exe url.dll,FileProtocolHandler !url!
endlocal

@TheRedDeveloper
Copy link
Copy Markdown
Author

To fix this you'd need to change fundamentally how the code works, so nope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants