[PTRun Unit Converter] Support for 'sq' prefixed units#37648
Closed
OldUser101 wants to merge 3 commits intomicrosoft:mainfrom
OldUser101:_PTRunUnitConverter37553
Closed
[PTRun Unit Converter] Support for 'sq' prefixed units#37648OldUser101 wants to merge 3 commits intomicrosoft:mainfrom OldUser101:_PTRunUnitConverter37553
OldUser101 wants to merge 3 commits intomicrosoft:mainfrom
OldUser101:_PTRunUnitConverter37553
Conversation
This comment has been minimized.
This comment has been minimized.
7 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for square units prefixed with "sq" by converting them into their equivalent "²" notation, enabling users to use units like "sqm" instead of "m^2".
- Introduces SquareHandler to handle conversion of "sq" prefixed units.
- Integrates the new handler in the Parse method for unit conversion queries.
Files not reviewed (1)
- .github/actions/spell-check/expect.txt: Language not supported
Contributor
|
Let's migrate to v2. |
Contributor
|
Close this PR due to another better impl has been merged. |
Contributor
|
I'm pleasure to help if anyone want to migrate it to v2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds support for square units prefixed with
sq. For example,sqmfor square metres, instead ofm^2.PR Checklist
Detailed Description of the Pull Request / Additional comments
Used simple substitution to swap
sqprefixed units with their^2equivalent. For example,sqftis substituted withft², which is supported by UnitsNet.For example, converting square feet to square metres can be done as follows:
Rather than:
This is additional to
^2suffixed units, which are still available.Validation Steps Performed
Basic testing done for each unit.