CmdPal: Extension list search by jiripolasek · Pull Request #41453 · microsoft/PowerToys

jiripolasek · 2025-08-28T23:04:56Z

Summary of the Pull Request

Adds a rough implementation that appears to work, but it hasn’t been tested. Don’t rely on it yet—I’m too tired to test properly or write a polished commit message.

Pictures? Pictures!

Recording.2025-10-07.162112.mp4

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Adds a rough implementation that appears to work, but it hasn’t been tested. Don’t rely on it yet—I’m too tired to test properly or write a polished commit message.

jiripolasek · 2025-08-28T23:08:26Z

@zadjii-msft @michaeljolley @niels9001 Keep this or drop it?

zadjii-msft · 2025-09-27T11:43:23Z

oh this is hawt

jiripolasek · 2025-09-27T11:50:16Z

Hi, I have to upgrade the collection backing up the list. I think some advanced collection from Toolkit should now be available.

zadjii-msft

This is super cool, definitely want to ship it. Let's just get rid of the weird tooltip from that automation property hanging around

src/modules/cmdpal/Microsoft.CmdPal.UI/Strings/en-us/Resources.resw

src/modules/cmdpal/Microsoft.CmdPal.UI/Settings/ExtensionsPage.xaml

src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/SettingsExtensionsViewModel.cs

jiripolasek · 2025-09-29T13:47:54Z

Do you want to ship this in 0.95? Just so I know how to prioritize this

jiripolasek · 2025-09-29T15:37:13Z

On way to wrap this up. While I'm sweeping away the spiders and bugs, does @niels9001 have any comments on how to improve or make it fit better?

niels9001 · 2025-09-29T16:23:47Z

@jiripolasek We had some thoughts around the call out for extensions.

PM art:

Mind if I push changes for this directly to this branch 😊?

jiripolasek · 2025-09-29T16:26:29Z

Sure, go ahead! Or if you don't have it coded yet, I can implement it for you. I have to double check everything in this branch anyway

…//github.com/jiripolasek/PowerToys into pr/41453

jiripolasek · 2025-09-29T16:50:42Z

@niels9001 Looking at the concept, I’m a bit worried the buttons might suffer from banner blindness. Something more conventional (or at least less bannerish) might work better.

niels9001 · 2025-09-29T19:12:26Z

@niels9001 Looking at the concept, I’m a bit worried the buttons might suffer from banner blindness. Something more conventional (or at least less bannerish) might work better.

Yeah, maybe. For activation, it feels like we need something at the top though - as by default the Store card is all the way at the bottom and might be hard to miss?

Settings experiences overall have a challenge conveying certain information, as everything is mostly a SettingsCard and they all look the same haha

jiripolasek · 2025-09-29T19:22:15Z

@niels9001 Looking at the concept, I’m a bit worried the buttons might suffer from banner blindness. Something more conventional (or at least less bannerish) might work better.

Yeah, maybe. For activation, it feels like we need something at the top though - as by default the Store card is all the way at the bottom and might be hard to miss?

With that, I can only agree. I didn’t want to push my luck by introducing any “random” new design elements and I hoped there will time to iterate on it.

Settings experiences overall have a challenge conveying certain information, as everything is mostly a SettingsCard and they all look the same haha

Here I was thinking that maybe plain toolbar-style buttons might do the trick. I’d throw in a green “+” icon (eco-friendly!) and hope for the best. Or maybe just lose the “box” to make it look less like a banner.

jiripolasek · 2025-09-29T19:44:26Z

Or something more compact:

jiripolasek · 2025-10-01T15:07:14Z

Mind if I push changes for this directly to this branch 😊?

@niels9001 Could you please mark the branch as Ready for review when you're done with it?

niels9001 · 2025-10-07T12:41:48Z

@jiripolasek I've synced with the design team. Their suggestion: jiripolasek#12

* Banner exploration * Updated UI * More feedback from design team * String update * Update ExtensionsPage.xaml * Update ExtensionsPage.xaml

jiripolasek · 2025-10-07T13:28:12Z

The WinGet button on the Extensions page is hidden because it requires summoning a specific page and handle possibility of WinGet extension being disabled: #42216

michaeljolley · 2025-10-10T13:22:08Z

/azp run

azure-pipelines · 2025-10-10T13:22:21Z

Azure Pipelines successfully started running 1 pipeline(s).

michaeljolley · 2025-10-10T16:38:28Z

/azp run

azure-pipelines · 2025-10-10T16:38:39Z

Azure Pipelines successfully started running 1 pipeline(s).

michaeljolley · 2025-10-11T18:51:31Z

That "Reload Extensions" button is blowing up for me.

System.Runtime.InteropServices.COMException
HResult=0x800706BA
Message=
Source=WinRT.Runtime
StackTrace:
at WinRT.ExceptionHelpers.g__Throw|38_0(Int32 hr)
at ABI.Microsoft.CommandPalette.Extensions.ICommandItemMethods.get_Title(IObjectReference _obj) in C:\sources\PowerToys\src\modules\cmdpal\extensionsdk\Microsoft.CommandPalette.Extensions.Toolkit\obj\x64\Debug\Generated Files\CsWinRT\Microsoft.CommandPalette.Extensions.cs:line 887
at ABI.Microsoft.CommandPalette.Extensions.ICommandItem.global::Microsoft.CommandPalette.Extensions.ICommandItem.get_Title() in C:\sources\PowerToys\src\modules\cmdpal\extensionsdk\Microsoft.CommandPalette.Extensions.Toolkit\obj\x64\Debug\Generated Files\CsWinRT\Microsoft.CommandPalette.Extensions.cs:line 1077
at Microsoft.CmdPal.Core.ViewModels.CommandItemViewModel.Command_PropertyChanged(Object sender, PropertyChangedEventArgs e) in C:\sources\PowerToys\src\modules\cmdpal\Core\Microsoft.CmdPal.Core.ViewModels\CommandItemViewModel.cs:line 401
at CommunityToolkit.Mvvm.ComponentModel.ObservableObject.OnPropertyChanged(PropertyChangedEventArgs e)
at CommunityToolkit.Mvvm.ComponentModel.ObservableObject.OnPropertyChanged(String propertyName)
at Microsoft.CmdPal.Core.ViewModels.ExtensionObjectViewModel.<>c__DisplayClass9_0.b__0() in C:\sources\PowerToys\src\modules\cmdpal\Core\Microsoft.CmdPal.Core.ViewModels\ExtensionObjectViewModel.cs:line 51
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)

jiripolasek · 2025-10-11T18:56:24Z

Oh, squirrel! I think that's #41482 manifesting in a new way

jiripolasek · 2025-10-11T19:27:33Z

@michaeljolley This won't crash the app, it just gets trapped by the debugger, right? I don't think there's anything to address here for this PR.

It seems like a natural error, as the Command Palette is trying to access an extension that was terminated (0x800706BA = RPC_S_SERVER_UNAVAILABLE). I couldn't respond to this even if I wanted to, as it occurs in a different or random code path.

jiripolasek · 2025-10-16T09:20:18Z

An anti-conflict team of highly trained squirrels was dispatched... 🐿️

michaeljolley

Copilot

Pull Request Overview

This PR adds a new extensions management page to the Command Palette settings UI with search, filtering, and reload capabilities. The changes introduce a banner to discover extensions, search functionality with keyboard shortcut support (Ctrl+F), and the ability to manually reload extensions.

Key changes:

New SettingsExtensionsViewModel to handle extension filtering and search
Enhanced ExtensionsPage.xaml with search UI, banner, and empty states
Messaging infrastructure for reload coordination via ReloadFinishedMessage

Reviewed Changes

Copilot reviewed 10 out of 14 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
Resources.resw	Adds localization strings for extensions page UI elements
ExtensionsPage.xaml	Implements new UI with banner, search box, filtering, and responsive layout
ExtensionsPage.xaml.cs	Adds keyboard accelerator handler for Ctrl+F search focus
SettingsExtensionsViewModel.cs	New view model implementing search/filter logic for extensions
TopLevelCommandManager.cs	Sends reload finished message after loading extensions
SettingsViewModel.cs	Instantiates and exposes the new Extensions view model
Properties/Resources.resx & Designer.cs	Adds format strings for extension count labels
ReloadFinishedMessage.cs	New message type for reload completion signaling
StoreLogo.dark.svg & StoreLogo.light.svg	Microsoft Store branding assets
WinGetLogo.svg	WinGet branding asset
Microsoft.CmdPal.UI.csproj	Registers new SVG assets
expect.txt	Adds "Figma" to spell-check dictionary

Files not reviewed (1)

src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Properties/Resources.Designer.cs: Language not supported

Copilot · 2025-11-07T02:07:14Z

src/modules/cmdpal/Microsoft.CmdPal.UI/Strings/en-us/Resources.resw

+    <value>Find extensions on WinGet</value>
+  </data>
+	<data name="Settings_ExtensionsPage_FindExtensions_WinGet.[using:Microsoft.UI.Xaml.Automation]AutomationProperties.Name" xml:space="preserve">
+    <value>Microsoft Store</value>


The AutomationProperties.Name for the WinGet button is incorrectly set to 'Microsoft Store'. It should be 'WinGet' to match the button's purpose and tooltip.

Suggested change

<value>Microsoft Store</value>

<value>WinGet</value>

Copilot · 2025-11-07T02:07:15Z

src/modules/cmdpal/Microsoft.CmdPal.UI/Strings/en-us/Resources.resw

+    <value>Reload extensions</value>
+  </data>
+  <data name="Settings_ExtensionsPage_Reloading_Text.Text" xml:space="preserve">
+    <value>Reloading extensions..</value>


Use a proper ellipsis character '…' or three periods '...' instead of two periods '..'.

Suggested change

<value>Reloading extensions..</value>

<value>Reloading extensions…</value>

Copilot · 2025-11-07T02:07:15Z

src/modules/cmdpal/Microsoft.CmdPal.UI/Settings/ExtensionsPage.xaml

+                        <!--<GradientStop Offset="0" Color="#E6F0FC" />
+                <GradientStop Offset="0.4" Color="#E6F0FC" />
+                <GradientStop Offset="1" Color="#F0F0F7" />-->


Remove commented-out code. If these gradient values might be needed later, document the reason in a separate comment or remove them entirely.

Suggested change

Copilot · 2025-11-07T02:07:15Z

src/modules/cmdpal/Microsoft.CmdPal.UI/Settings/ExtensionsPage.xaml

+                        <GradientStop Offset="1.0" Color="#FFF5F8FA" />
+                        <!--  Slight bluish-gray tint  -->
+                        <!--  Faint peach glow  -->
+                        <!--  Soft peach  -->


These orphaned comments reference colors that are not present in the code. Remove them to avoid confusion.

Suggested change

## Summary of the Pull Request Adds a rough implementation that appears to work, but it hasn’t been tested. Don’t rely on it yet—I’m too tired to test properly or write a polished commit message. Pictures? Pictures! <img width="2720" height="1624" alt="image" src="https://github.com/user-attachments/assets/4f9c3360-8d08-4a34-888f-c6890afd0159" /> <img width="2647" height="1558" alt="image" src="https://github.com/user-attachments/assets/3d6c23bc-f26d-4e31-ae09-d91efd304048" /> <img width="2683" height="1536" alt="image" src="https://github.com/user-attachments/assets/6017b2d4-ccd9-4555-b81f-e2b1f78c48e5" /> <img width="577" height="334" alt="image" src="https://github.com/user-attachments/assets/987fea99-05b2-4d31-b90c-327122daa241" /> https://github.com/user-attachments/assets/65a8f8ce-ae09-4272-881d-0b6f56cecfae  ## PR Checklist - [x] Closes: #41451 - [x] Closes: #42031 - [x] Closes: #41800 - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx  ## Detailed Description of the Pull Request / Additional comments  ## Validation Steps Performed --------- Co-authored-by: Niels Laute <niels.laute@live.nl> Co-authored-by: Michael Jolley <mike@baldbeardedbuilder.com>

Initial prototype for extension list search

456ace1

Adds a rough implementation that appears to work, but it hasn’t been tested. Don’t rely on it yet—I’m too tired to test properly or write a polished commit message.

zadjii-msft added the Product-Command Palette Refers to the Command Palette utility label Sep 2, 2025

jiripolasek mentioned this pull request Sep 26, 2025

Make Command Pallet Extensions More Discoverable #42031

Closed

Merge main

7fc0dce

zadjii-msft reviewed Sep 29, 2025

View reviewed changes

jiripolasek and others added 3 commits September 29, 2025 18:29

Tweaks

939b542

Merge branch 'main' into pr/41453

18a4150

Merge branch 'experiment/cmdpal-settings-extensions-filter' of https:…

6a09c01

…//github.com/jiripolasek/PowerToys into pr/41453

jiripolasek changed the title ~~CmdPal: Extension list search [experiment]~~ CmdPal: Extension list search Sep 29, 2025

jiripolasek added 2 commits September 29, 2025 19:41

Fix merge

b666df3

Move UI strings to resources

c49883e

niels9001 and others added 3 commits October 7, 2025 15:03

Extensions buttons (#12)

44d8da5

* Banner exploration * Updated UI * More feedback from design team * String update * Update ExtensionsPage.xaml * Update ExtensionsPage.xaml

Merge branch 'main' into experiment/cmdpal-settings-extensions-filter

a1b19ba

Add Figma to spellchecker

675c109

This comment has been minimized.

Sign in to view

jiripolasek marked this pull request as ready for review October 7, 2025 13:16

jiripolasek requested a review from zadjii-msft October 7, 2025 13:17

jiripolasek mentioned this pull request Oct 7, 2025

CmdPal: Settings - Integrate WinGet to Extensions list #42216

Open

niels9001 added the In for .96 label Oct 9, 2025

niels9001 requested a review from michaeljolley October 11, 2025 15:13

jiripolasek and others added 4 commits October 17, 2025 00:44

Merge main

224ae6d

Merge branch 'main' into experiment/cmdpal-settings-extensions-filter

ac9ad4c

Merge main

c0b0d5f

Fix search box placeholder text

91d08e5

michaeljolley approved these changes Oct 28, 2025

View reviewed changes

michaeljolley merged commit 1e40d6b into microsoft:main Oct 28, 2025
10 checks passed

jiripolasek mentioned this pull request Nov 6, 2025

Publish extension updates MicrosoftDocs/windows-dev-docs#5698

Merged

yeelam-gordon requested a review from Copilot November 7, 2025 01:56

Copilot AI reviewed Nov 7, 2025

View reviewed changes

yeelam-gordon added this to the PowerToys 0.96 milestone Nov 11, 2025

	<value>Reloading extensions..</value>
	<value>Reloading extensions…</value>

	<!--<GradientStop Offset="0" Color="#E6F0FC" />
	<GradientStop Offset="0.4" Color="#E6F0FC" />
	<GradientStop Offset="1" Color="#F0F0F7" />-->

Comments

Conversation

jiripolasek commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Uh oh!

jiripolasek commented Aug 28, 2025

Uh oh!

zadjii-msft commented Sep 27, 2025

Uh oh!

jiripolasek commented Sep 27, 2025

Uh oh!

zadjii-msft left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jiripolasek commented Sep 29, 2025

Uh oh!

jiripolasek commented Sep 29, 2025

Uh oh!

niels9001 commented Sep 29, 2025

Uh oh!

jiripolasek commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jiripolasek commented Sep 29, 2025

Uh oh!

niels9001 commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jiripolasek commented Sep 29, 2025

Uh oh!

jiripolasek commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jiripolasek commented Oct 1, 2025

Uh oh!

niels9001 commented Oct 7, 2025

Uh oh!

This comment has been minimized.

jiripolasek commented Oct 7, 2025

Uh oh!

michaeljolley commented Oct 10, 2025

Uh oh!

azure-pipelines bot commented Oct 10, 2025

Uh oh!

michaeljolley commented Oct 10, 2025

Uh oh!

azure-pipelines bot commented Oct 10, 2025

Uh oh!

michaeljolley commented Oct 11, 2025

Uh oh!

jiripolasek commented Oct 11, 2025

Uh oh!

jiripolasek commented Oct 11, 2025

Uh oh!

jiripolasek commented Oct 16, 2025

Uh oh!

michaeljolley left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

jiripolasek commented Aug 28, 2025 •

edited

Loading

jiripolasek commented Sep 29, 2025 •

edited

Loading

niels9001 commented Sep 29, 2025 •

edited

Loading

jiripolasek commented Sep 29, 2025 •

edited

Loading