[CmdPal] Extension string updates#43269
Conversation
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.System/Properties/Resources.resx
Outdated
Show resolved
Hide resolved
|
@niels9001 I don't see any changes in the |
Oops, I was skipping those thinking those would were auto-generated. What's your suggestion I do :)? |
|
@niels9001 Open the files in big Visual Studio and open each modified .RESX file, or right-click on the file in the Solution Explorer and select "Run Custom Tool" from the context menu. It can be also done by |
|
@niels9001 @michaeljolley A small UX guide or a set of recommendations for third-party extension developers would be great to ensure consistency across the board. 😇 For me personally, having a mix of items with subtitles and without feels a bit disruptive :/ |
Yeah, that'd be great to have in the docs I guess.. and for 1P extensions to actually follow up those guidelines too haha :). Also where to put hints (e.g. the Calculator hint feels weird, and should that be in the searchbox whenever you select the command)? I think we should aim at keeping things as simple as possible - and only use subtitles when a title would not suffice to explain what the action entails. |
|
Yeah. I agree. Subtitles for things like calculator do seem better in the search box as a hint within the specific extension. The benefit of no subtitles is that more results can be shown at one time. If we leave subtitles, perhaps we "fake" an empty subtitle when it isn't available so we can have standard sizes. |
…microsoft/PowerToys into niels9001/cmdpal-string-updates
|
@niels9001, synced the cs/resx for you. Not sure if you can approve this now. Since I was the last to push I definitely can't. |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.TimeDate/Properties/Resources.Designer.cs
Fixed
Show fixed
Hide fixed
This comment has been minimized.
This comment has been minimized.
Fixes the spelling issue it caused.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. These words are not needed and should be removedcabstr CIBUILD djwsxzxb icf installscopeperuser ksa Olllama rap registryroot regroot rtm suntimes TARGETDIR utmPattern suggestions ✂️ (1)You could add these patterns to Alternatively, if a pattern suggestion doesn't make sense for this project, add a If the flagged items are 🤯 false positivesIf items relate to a ...
|
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes capitalization and wording across user-facing strings in PowerToys Run plugins and Command Palette extensions. The main focus is improving consistency and clarity in descriptions, titles, and command names.
Key Changes
- Updated capitalization to use lowercase for common nouns (e.g., "UEFI Firmware Settings" → "UEFI firmware settings", "Time and Date" → "Time and date")
- Improved action-oriented command titles (e.g., "Windows Services" → "Manage Windows services", "Registry" → "Browse the Windows registry")
- Removed redundant subtitle properties to simplify UI presentation
- Updated corresponding unit tests and UI tests to match new string values
Reviewed Changes
Copilot reviewed 24 out of 33 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.TimeDate/Properties/Resources.resx |
Changed plugin description verb from "Provides" to "Shows" |
src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.System/Properties/Resources.resx |
Lowercased "settings" in UEFI-related strings |
src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.System/Properties/Resources.Designer.cs |
Auto-generated changes for resource tool version |
src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.System.UnitTests/QueryTests.cs |
Updated test assertion to match new UEFI string |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/Properties/Resources.resx |
Lowercased "profiles" in command title |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/Properties/Resources.Designer.cs |
Auto-generated Designer.cs update |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsServices/WindowsServicesCommandsProvider.cs |
Changed to action-oriented title "Manage Windows services", removed subtitle |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowWalker/Properties/Resources.resx |
Lowercased "responding" and "desktops" in status strings |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowWalker/Properties/Resources.Designer.cs |
Auto-generated Designer.cs update |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WinGet/WinGetExtensionCommandsProvider.cs |
Removed subtitle property |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WinGet/Properties/Resources.resx |
Updated command titles for clarity, removed subtitle resource |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WinGet/Properties/Resources.Designer.cs |
Auto-generated Designer.cs update removing subtitle property |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.TimeDate/Properties/Resources.resx |
Lowercased "date" in plugin name, changed verb to "Show", removed unused conjunction list |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.TimeDate/Properties/Resources.Designer.cs |
Auto-generated Designer.cs update |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.TimeDate/Helpers/TimeDateCalculator.cs |
Removed unused conjunction list field |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.System/Properties/Resources.resx |
Lowercased common nouns, improved punctuation in confirmation message |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.System/Properties/Resources.Designer.cs |
Auto-generated Designer.cs update |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Shell/Properties/Resources.resx |
Improved command description clarity |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Shell/Properties/Resources.Designer.cs |
Auto-generated Designer.cs update |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Registry/RegistryCommandsProvider.cs |
Changed to descriptive action title, removed subtitle |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Properties/Resources.resx |
Removed subtitle resource |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Properties/Resources.Designer.cs |
Auto-generated Designer.cs update |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Pages/IndexerPage.cs |
Removed subtitle assignment |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/IndexerCommandsProvider.cs |
Removed subtitle assignment |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/FallbackOpenFileItem.cs |
Removed subtitle assignment |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Apps/Properties/Resources.resx |
Simplified app search strings, removed subtitle resource |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Apps/Properties/Resources.Designer.cs |
Auto-generated Designer.cs update |
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Apps/AllAppsCommandProvider.cs |
Removed subtitle assignment |
src/modules/cmdpal/Tests/Microsoft.CmdPal.UITests/BasicTests.cs |
Updated UI test expectations to match new strings |
src/modules/cmdpal/Tests/Microsoft.CmdPal.Ext.TimeDate.UnitTests/TimeDateCommandsProviderTests.cs |
Updated test assertion for new plugin description |
src/modules/cmdpal/Tests/Microsoft.CmdPal.Ext.System.UnitTests/QueryTests.cs |
Updated test assertions and DataRow values for new UEFI strings |
src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Properties/Resources.resx |
Simplified built-in command strings, removed subtitle resource |
src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Commands/BuiltInsCommandProvider.cs |
Removed subtitle assignment |
Files not reviewed (9)
- src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Apps/Properties/Resources.Designer.cs: Language not supported
- src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Properties/Resources.Designer.cs: Language not supported
- src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Shell/Properties/Resources.Designer.cs: Language not supported
- src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.System/Properties/Resources.Designer.cs: Language not supported
- src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.TimeDate/Properties/Resources.Designer.cs: Language not supported
- src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WinGet/Properties/Resources.Designer.cs: Language not supported
- src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowWalker/Properties/Resources.Designer.cs: Language not supported
- src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/Properties/Resources.Designer.cs: Language not supported
- src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.System/Properties/Resources.Designer.cs: Language not supported
| </data> | ||
| <data name="Microsoft_plugin_sys_uefi_description" xml:space="preserve"> | ||
| <value>Reboot computer into UEFI Firmware Settings (Requires administrative permissions.)</value> | ||
| <value>Reboot computer into UEFI firmware Settings (requires administrative permissions.)</value> |
There was a problem hiding this comment.
Inconsistent capitalization: "Settings" should be lowercase "settings" to match the other UEFI-related strings in this file (lines 394, 398).
| <value>Reboot computer into UEFI firmware Settings (requires administrative permissions.)</value> | |
| <value>Reboot computer into UEFI firmware settings (requires administrative permissions.)</value> |
|
|
||
| /// <summary> | ||
| /// Looks up a localized string similar to Open System Command. | ||
| /// Looks up a localized string similar to Open system command. |
There was a problem hiding this comment.
The Designer.cs file is out of sync with the .resx file. The corresponding resource string in Resources.resx (line 418) says "Execute system commands" but this Designer.cs comment shows "Open system command". The Designer.cs file needs to be regenerated from the .resx file.
| /// Looks up a localized string similar to Open system command. | |
| /// Looks up a localized string similar to Execute system commands. |
|
|
||
| /// <summary> | ||
| /// Looks up a localized string similar to Reboot computer into UEFI Firmware Settings (Requires administrative permissions.). | ||
| /// Looks up a localized string similar to Reboot computer into UEFI firmware Settings (requires administrative permissions.). |
There was a problem hiding this comment.
The Designer.cs file is out of sync with the .resx file. The corresponding resource string in Resources.resx (line 402) says "Reboot computer into UEFI firmware Settings (requires administrative permissions.)" but this Designer.cs comment shows the old text. The Designer.cs file needs to be regenerated from the .resx file.
| </data> | ||
| <data name="Microsoft_plugin_sys_uefi_confirmation" xml:space="preserve"> | ||
| <value>You are about to reboot this computer into UEFI Firmware Settings menu, are you sure?</value> | ||
| <value>You are about to reboot this computer into UEFI firmware settings menu, are you sure?</value> |
There was a problem hiding this comment.
Inconsistent punctuation and capitalization: Should add a period after "menu" and capitalize "Are" to match the format used in line 330 for the restart confirmation message.
| <value>You are about to reboot this computer into UEFI firmware settings menu, are you sure?</value> | |
| <value>You are about to reboot this computer into UEFI firmware settings menu. Are you sure?</value> |
| </data> | ||
| <data name="Microsoft_plugin_sys_uefi_confirmation" xml:space="preserve"> | ||
| <value>You are about to reboot this computer into UEFI Firmware Settings menu, are you sure?</value> | ||
| <value>You are about to reboot this computer into UEFI firmware settings menu, are you sure?</value> |
There was a problem hiding this comment.
Inconsistent punctuation and capitalization: Should add a period after "menu" and capitalize "Are" to match the format used elsewhere in the codebase for confirmation messages (e.g., "You are about to restart this computer. Are you sure?" in the cmdpal extension).

Summary of the Pull Request
Feedback from the design team:
Verb + nounfor most extensionsPR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed