Conversation
This fixes some static analysis warnings in C++ projects that onboard to using WIL.
|
@DHowett Is this PR still relevant or stale? |
|
@niels9001 well! if the version of wil in use in the codebase is less than 1.0.250325.1 then yes it is still relevant. If greater or equal, then no. |
|
@copilot resolve merge conflicts |
…es.props Co-authored-by: niels9001 <9866362+niels9001@users.noreply.github.com>
Merge conflicts resolved in e3016ec. Main had migrated all C++ projects to Central Package Management ( |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Windows Implementation Library (WIL) NuGet version across the repo to address C++ static analysis warnings, including updating the centrally managed package version.
Changes:
- Bumped
Microsoft.Windows.ImplementationLibraryfrom1.0.231216.1to1.0.250325.1inDirectory.Packages.props. - Updated per-project
packages.configentries for WIL in two native projects.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/modules/MouseWithoutBorders/ModuleInterface/packages.config | Updates WIL version in legacy packages.config reference. |
| src/common/COMUtils/packages.config | Updates WIL version in legacy packages.config reference. |
| Directory.Packages.props | Updates centrally-managed WIL package version used by PackageReference projects. |
| <packages> | ||
| <package id="Microsoft.Windows.ImplementationLibrary" version="1.0.231216.1" targetFramework="native" /> | ||
| </packages> No newline at end of file | ||
| <package id="Microsoft.Windows.ImplementationLibrary" version="1.0.250325.1" targetFramework="native" /> |
There was a problem hiding this comment.
The PR description says WIL is managed centrally via Directory.Packages.props (Central Package Management) and replaces per-project packages.config, but this change still updates packages.config. Central Package Management does not apply to packages.config, so this introduces/keeps two sources of truth. Either (a) migrate these native projects off packages.config to PackageReference so they pick up the centralized version, or (b) update the PR description to clarify that some projects still use packages.config and require manual version bumps.
| --> | ||
| <PackageVersion Include="Microsoft.Windows.CsWinRT" Version="2.2.0" /> | ||
| <PackageVersion Include="Microsoft.Windows.ImplementationLibrary" Version="1.0.231216.1"/> | ||
| <PackageVersion Include="Microsoft.Windows.ImplementationLibrary" Version="1.0.250325.1"/> |
There was a problem hiding this comment.
Formatting is inconsistent with surrounding PackageVersion entries (which use />). Consider updating this line to include a space before the self-closing tag (... Version=\"1.0.250325.1\" />) to keep the XML style consistent and reduce noisy diffs in future edits.
| <PackageVersion Include="Microsoft.Windows.ImplementationLibrary" Version="1.0.250325.1"/> | |
| <PackageVersion Include="Microsoft.Windows.ImplementationLibrary" Version="1.0.250325.1" /> |
|
Why is Copilot reviewing already-merged PRs, @LegendaryBlair? |
Summary of the Pull Request
Updates the Windows Implementation Library (WIL) to version 1.0.250325.1. This fixes some static analysis warnings in C++ projects that use WIL.
The version is now managed centrally via
Directory.Packages.props(Central Package Management), replacing the previous per-projectpackages.configapproach.PR Checklist
Detailed Description of the Pull Request / Additional comments
Microsoft.Windows.ImplementationLibraryfrom1.0.231216.1to1.0.250325.1inDirectory.Packages.props.PackageReferencewithout specifying a version number directly.Validation Steps Performed
Directory.Packages.propscorrectly reflects the new WIL version1.0.250325.1.mainbranch to resolve conflicts arising from the migration to Central Package Management.