Skip to content

chore: Update to WIL 1.0.250325.1#43503

Merged
niels9001 merged 2 commits intomainfrom
dev/duhowett/wil-they-wont-they
Apr 1, 2026
Merged

chore: Update to WIL 1.0.250325.1#43503
niels9001 merged 2 commits intomainfrom
dev/duhowett/wil-they-wont-they

Conversation

@DHowett
Copy link
Copy Markdown
Member

@DHowett DHowett commented Nov 12, 2025

Summary of the Pull Request

Updates the Windows Implementation Library (WIL) to version 1.0.250325.1. This fixes some static analysis warnings in C++ projects that use WIL.

The version is now managed centrally via Directory.Packages.props (Central Package Management), replacing the previous per-project packages.config approach.

PR Checklist

  • Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end-user-facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

  • Updated Microsoft.Windows.ImplementationLibrary from 1.0.231216.1 to 1.0.250325.1 in Directory.Packages.props.
  • The change is a single-line update since the codebase uses Central Package Management — all C++ projects reference WIL via PackageReference without specifying a version number directly.

Validation Steps Performed

  • Verified Directory.Packages.props correctly reflects the new WIL version 1.0.250325.1.
  • Merged latest main branch to resolve conflicts arising from the migration to Central Package Management.

This fixes some static analysis warnings in C++ projects that onboard to using WIL.
@DHowett DHowett requested a review from a team as a code owner November 12, 2025 16:55
@niels9001
Copy link
Copy Markdown
Collaborator

@DHowett Is this PR still relevant or stale?

@DHowett
Copy link
Copy Markdown
Member Author

DHowett commented Mar 4, 2026

@niels9001 well! if the version of wil in use in the codebase is less than 1.0.250325.1 then yes it is still relevant. If greater or equal, then no.

@niels9001
Copy link
Copy Markdown
Collaborator

@copilot resolve merge conflicts

…es.props

Co-authored-by: niels9001 <9866362+niels9001@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 1, 2026

@copilot resolve merge conflicts

Merge conflicts resolved in e3016ec. Main had migrated all C++ projects to Central Package Management (Directory.Packages.props), so the individual packages.config changes from the original commit are now superseded. The WIL version bump to 1.0.250325.1 is now applied via a single entry in Directory.Packages.props.

Copilot AI requested a review from niels9001 April 1, 2026 07:54
@vanzue
Copy link
Copy Markdown
Contributor

vanzue commented Apr 1, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@niels9001 niels9001 enabled auto-merge (squash) April 1, 2026 08:56
@niels9001 niels9001 merged commit 36a5b77 into main Apr 1, 2026
15 checks passed
@LegendaryBlair LegendaryBlair added this to the PowerToys 0.99 milestone Apr 15, 2026
@LegendaryBlair LegendaryBlair added the Area-Build Issues pertaining to the build system, CI, infrastructure, meta label Apr 15, 2026
@LegendaryBlair LegendaryBlair requested a review from Copilot April 15, 2026 07:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the Windows Implementation Library (WIL) NuGet version across the repo to address C++ static analysis warnings, including updating the centrally managed package version.

Changes:

  • Bumped Microsoft.Windows.ImplementationLibrary from 1.0.231216.1 to 1.0.250325.1 in Directory.Packages.props.
  • Updated per-project packages.config entries for WIL in two native projects.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/modules/MouseWithoutBorders/ModuleInterface/packages.config Updates WIL version in legacy packages.config reference.
src/common/COMUtils/packages.config Updates WIL version in legacy packages.config reference.
Directory.Packages.props Updates centrally-managed WIL package version used by PackageReference projects.

<packages>
<package id="Microsoft.Windows.ImplementationLibrary" version="1.0.231216.1" targetFramework="native" />
</packages> No newline at end of file
<package id="Microsoft.Windows.ImplementationLibrary" version="1.0.250325.1" targetFramework="native" />
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says WIL is managed centrally via Directory.Packages.props (Central Package Management) and replaces per-project packages.config, but this change still updates packages.config. Central Package Management does not apply to packages.config, so this introduces/keeps two sources of truth. Either (a) migrate these native projects off packages.config to PackageReference so they pick up the centralized version, or (b) update the PR description to clarify that some projects still use packages.config and require manual version bumps.

Copilot uses AI. Check for mistakes.
Comment thread Directory.Packages.props
-->
<PackageVersion Include="Microsoft.Windows.CsWinRT" Version="2.2.0" />
<PackageVersion Include="Microsoft.Windows.ImplementationLibrary" Version="1.0.231216.1"/>
<PackageVersion Include="Microsoft.Windows.ImplementationLibrary" Version="1.0.250325.1"/>
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting is inconsistent with surrounding PackageVersion entries (which use />). Consider updating this line to include a space before the self-closing tag (... Version=\"1.0.250325.1\" />) to keep the XML style consistent and reduce noisy diffs in future edits.

Suggested change
<PackageVersion Include="Microsoft.Windows.ImplementationLibrary" Version="1.0.250325.1"/>
<PackageVersion Include="Microsoft.Windows.ImplementationLibrary" Version="1.0.250325.1" />

Copilot uses AI. Check for mistakes.
@DHowett
Copy link
Copy Markdown
Member Author

DHowett commented Apr 15, 2026

Why is Copilot reviewing already-merged PRs, @LegendaryBlair?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Build Issues pertaining to the build system, CI, infrastructure, meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants