Skip to content

More extension gallery changes#46752

Merged
jiripolasek merged 7 commits intodev/jpolasek/f/46628-cmdpal-extension-galleryfrom
niels9001/extensionjson
Apr 3, 2026
Merged

More extension gallery changes#46752
jiripolasek merged 7 commits intodev/jpolasek/f/46628-cmdpal-extension-galleryfrom
niels9001/extensionjson

Conversation

@niels9001
Copy link
Copy Markdown
Collaborator

Summary of the Pull Request

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end-user-facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@github-actions

This comment has been minimized.

@niels9001 niels9001 force-pushed the niels9001/extensionjson branch from 624af67 to 6e8cbb6 Compare April 3, 2026 09:35
@github-actions

This comment has been minimized.


public string? IconDark { get; set; }

public string? IconUrl { get; set; }
Copy link
Copy Markdown
Collaborator

@jiripolasek jiripolasek Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this: this would allow somebody to track the users or update the content of the URL after we approve it. Since we will display this directly in the UI, we should not allow unchecked updates.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. did this break the icon loading?

image

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me take a look 😮

@github-actions

This comment has been minimized.

@niels9001 niels9001 marked this pull request as ready for review April 3, 2026 12:01
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

This reverts commit eec8c22.
@jiripolasek jiripolasek merged commit d3ba693 into dev/jpolasek/f/46628-cmdpal-extension-gallery Apr 3, 2026
9 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (15)
Codesfor
Colorsfor
Controlsfor
demonstrujici
DRHJ
Filesfor
fintz
manifestu
NCFD
Numbersfor
NZVS
segoe
tmdb
traies
udit
These words are not needed and should be removed IPREVIEW ITHUMBNAIL LPCFHOOKPROC LUMA MAXDWORD MRT suntimes timespan VSync

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the git@github.com:microsoft/PowerToys.git repository
on the niels9001/extensionjson branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/c635c2f3f714eec2fcf27b643a1919b9a811ef2e/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/23956106715/attempts/1' &&
git commit -m 'Update check-spelling metadata'
Forbidden patterns 🙅 (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

Should be WinGet

\bWinget\b
Errors and Warnings ❌ (2)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 10
⚠️ ignored-expect-variant 6

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants