More extension gallery changes#46752
More extension gallery changes#46752jiripolasek merged 7 commits intodev/jpolasek/f/46628-cmdpal-extension-galleryfrom
Conversation
This comment has been minimized.
This comment has been minimized.
624af67 to
6e8cbb6
Compare
This comment has been minimized.
This comment has been minimized.
|
|
||
| public string? IconDark { get; set; } | ||
|
|
||
| public string? IconUrl { get; set; } |
There was a problem hiding this comment.
I don't like this: this would allow somebody to track the users or update the content of the URL after we approve it. Since we will display this directly in the UI, we should not allow unchecked updates.
src/modules/cmdpal/Microsoft.CmdPal.UI/Settings/ExtensionGalleryDetailPage.xaml
Fixed
Show fixed
Hide fixed
src/modules/cmdpal/Microsoft.CmdPal.UI/Settings/ExtensionGalleryDetailPage.xaml
Fixed
Show fixed
Hide fixed
This comment has been minimized.
This comment has been minimized.
src/modules/cmdpal/Microsoft.CmdPal.UI/Settings/ExtensionGalleryDetailPage.xaml
Fixed
Show fixed
Hide fixed
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This reverts commit eec8c22.
d3ba693
into
dev/jpolasek/f/46628-cmdpal-extension-gallery
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (15)These words are not needed and should be removedIPREVIEW ITHUMBNAIL LPCFHOOKPROC LUMA MAXDWORD MRT suntimes timespan VSyncTo accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the git@github.com:microsoft/PowerToys.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/c635c2f3f714eec2fcf27b643a1919b9a811ef2e/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/23956106715/attempts/1' &&
git commit -m 'Update check-spelling metadata'Forbidden patterns 🙅 (1)In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves. These forbidden patterns matched content: Should be
|
| ❌ Errors and Warnings | Count |
|---|---|
| ❌ forbidden-pattern | 10 |
| 6 |
See ❌ Event descriptions for more information.
If the flagged items are 🤯 false positives
If items relate to a ...
-
binary file (or some other file you wouldn't want to check at all).
Please add a file path to the
excludes.txtfile matching the containing file.File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.
^refers to the file's path from the root of the repository, so^README\.md$would exclude README.md (on whichever branch you're using). -
well-formed pattern.
If you can write a pattern that would match it,
try adding it to thepatterns.txtfile.Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.
Note that patterns can't match multiline strings.

Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed