Skip to content

CmdPal: Fix a bug where dock label settings wouldn't save#47317

Merged
zadjii-msft merged 1 commit intomainfrom
dev/migrie/b/dock-titles-settings
Apr 29, 2026
Merged

CmdPal: Fix a bug where dock label settings wouldn't save#47317
zadjii-msft merged 1 commit intomainfrom
dev/migrie/b/dock-titles-settings

Conversation

@zadjii-msft
Copy link
Copy Markdown
Member

This setting is totally vestigial, from the 0.9 dev cycle.

Unfortunately, the JSON parser would see that it wasn't in the settings.json, then it would write null to it. But ShowLabels was just a thin alias for ShowTitles, so we'd end up parsing totally sane JSON settings into having null for ShowTitle.

This fixes that. You can hide your titles again folks.

@zadjii-msft zadjii-msft added Product-Command Palette Refers to the Command Palette utility 0.99-hotfix labels Apr 28, 2026
@zadjii-msft zadjii-msft enabled auto-merge (squash) April 28, 2026 21:52
@github-actions
Copy link
Copy Markdown

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.

Unrecognized words (1)

DEFAULTTONEAREST

These words are not needed and should be removed defaulttonearest

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the git@github.com:microsoft/PowerToys.git repository
on the dev/migrie/b/dock-titles-settings branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/cfb6f7e75bbfc89c71eaa30366d0c166f1bd9c8c/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/25079578286/attempts/1' &&
git commit -m 'Update check-spelling metadata'

OR

To have the bot accept them for you, comment in the PR quoting the following line:
@check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@zadjii-msft zadjii-msft merged commit b835cde into main Apr 29, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.99-hotfix Product-Command Palette Refers to the Command Palette utility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants