Replay both key down and up for Win in GrabAndMove#47326
Replay both key down and up for Win in GrabAndMove#47326LegendaryBlair merged 1 commit intomicrosoft:mainfrom
Conversation
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.Unrecognized words (1)DEFAULTTONEAREST These words are not needed and should be removeddefaulttonearestTo accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the git@github.com:foxmsft/PowerToys.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/cfb6f7e75bbfc89c71eaa30366d0c166f1bd9c8c/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/25083302088/attempts/1' &&
git commit -m 'Update check-spelling metadata'If the flagged items are 🤯 false positivesIf items relate to a ...
|
Summary of the Pull Request
The code for keyup on the
Winkey would replay the previously absorbed keydown event and just leave this keyup to propagate normally, thus leading to a race condition betweenCallNextHookExandSendInput. This resulted in almost guaranteed out-of-order event (Winup, followed byWindown) in the case ofWin+G(the Xbox Game bar shortcut).Fixed by also absorbing the keyup for
Win, but callingSendInputfor both keydown and keyup.PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed