Skip to content

bootstrapper: treat invalid flags as fatal errors#7405

Merged
yuyoyuppe merged 1 commit intomicrosoft:masterfrom
yuyoyuppe:issue_6216
Oct 21, 2020
Merged

bootstrapper: treat invalid flags as fatal errors#7405
yuyoyuppe merged 1 commit intomicrosoft:masterfrom
yuyoyuppe:issue_6216

Conversation

@yuyoyuppe
Copy link
Copy Markdown
Contributor

Summary of the Pull Request

  • show help and exit instead of ignoring invalid flags

PR Checklist

Validation Steps Performed

  • try invalid flags
  • try invalid arguments for flags
  • try valid flags

@yuyoyuppe yuyoyuppe requested a review from enricogior October 20, 2020 09:09
@enricogior enricogior added the Area-Setup/Install Refers to installation mechanism label Oct 21, 2020
@htcfreek
Copy link
Copy Markdown
Collaborator

I think we should open a new issue as reminder to update the params list in Wiki.

@enricogior
Copy link
Copy Markdown
Contributor

@yuyoyuppe
dos it already support the log_dir flag? Or should this PR be updated after #7406 is merged?

@yuyoyuppe
Copy link
Copy Markdown
Contributor Author

@enricogior sure, it's a separate PR.

@yuyoyuppe yuyoyuppe merged commit 9c341cc into microsoft:master Oct 21, 2020
@yuyoyuppe yuyoyuppe deleted the issue_6216 branch October 21, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Setup/Install Refers to installation mechanism

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants