Skip to content

updating: add support for prereleases#8296

Merged
yuyoyuppe merged 1 commit intomicrosoft:masterfrom
yuyoyuppe:issue_8291
Dec 10, 2020
Merged

updating: add support for prereleases#8296
yuyoyuppe merged 1 commit intomicrosoft:masterfrom
yuyoyuppe:issue_8291

Conversation

@yuyoyuppe
Copy link
Copy Markdown
Contributor

Summary of the Pull Request

We need a different method of updating when using Github's prerelease API.

PR Checklist

Validation Steps Performed

  • update from a local build with the 0.0-version-check commented out

Copy link
Copy Markdown
Contributor

@SeraphimaZykova SeraphimaZykova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with different prerelease flags, LGTM.

@ghost ghost added Area-Setup/Install Refers to installation mechanism Idea-Enhancement New feature or request on an existing product labels Dec 2, 2020
@crutkas
Copy link
Copy Markdown
Member

crutkas commented Dec 4, 2020

what is left to merge this in?

@enricogior
Copy link
Copy Markdown
Contributor

@crutkas
my approval, I've been overwhelmed with investigating some new issues.

@yuyoyuppe yuyoyuppe merged commit 84932eb into microsoft:master Dec 10, 2020
@yuyoyuppe yuyoyuppe deleted the issue_8291 branch December 10, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Setup/Install Refers to installation mechanism Idea-Enhancement New feature or request on an existing product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants