Fix ASCII lifecycle diagram alignment#139
Conversation
Alan-Jowett
force-pushed
the
fix/readme-diagram-alignment
branch
from
640a108 to
a3c3e89
Compare
Widen boxes to 20 chars, add consistent spacing, align feedback arrow with Maintain box center. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Alan-Jowett
force-pushed
the
fix/readme-diagram-alignment
branch
from
a3c3e89 to
7a9b296
Compare
There was a problem hiding this comment.
Pull request overview
Updates the README’s “Engineering Lifecycle” ASCII diagram to improve visual consistency and readability, aligning with PromptKit’s documentation-first nature.
Changes:
- Widen lifecycle diagram boxes to a consistent 20-character width.
- Adjust spacing and the return/feedback loop layout to improve alignment.
| │ extract specs │ │ changes with │ │ correct specs │ | ||
| │ (req / design │ │ adversarial │ │ and code │ | ||
| │ / validation) │ │ audits │ │ │ | ||
| └──────────────────┘ └──────────────────┘ └────────┬─────────┘ |
There was a problem hiding this comment.
The Maintain box bottom border includes a ┬ junction, but the vertical return-path │ on the next line is aligned with the far right edge (┘) rather than directly under that ┬. This makes the feedback arrow originate from the corner instead of the box center (and visually leaves the ┬ unconnected). Consider shifting the vertical │ (and the horizontal return line) left to align under the ┬, or remove the ┬ if the return path is intended to connect at the corner.
| └──────────────────┘ └──────────────────┘ └────────┬─────────┘ | |
| └──────────────────┘ └──────────────────┘ └──────────────────┘ |
| └───────────────────────────────────────────────┘ | ||
| drift detected | ||
| ┌──────────────────┐ ┌──────────────────┐ ┌──────────────────┐ | ||
| │ Bootstrap │────>│ Evolve │────>│ Maintain │ |
There was a problem hiding this comment.
In the 20-character-wide boxes (18-char interior), the "Maintain" label padding looks uneven (│ Maintain │ has 4 spaces before and 6 after), so the title is slightly left-shifted compared to the other boxes. For a centered label, the left/right padding should split the remaining 10 spaces evenly (5 and 5).
| │ Bootstrap │────>│ Evolve │────>│ Maintain │ | |
| │ Bootstrap │────>│ Evolve │────>│ Maintain │ |
Fix the engineering lifecycle ASCII diagram — widen boxes to 20 chars with consistent spacing, align the feedback arrow with the Maintain box center.