FEAT Added analyze_results#1003
Merged
Merged
Conversation
romanlutz
reviewed
Jul 13, 2025
romanlutz
left a comment
romanlutz
left a comment
Contributor
There was a problem hiding this comment.
This is a great start for the analytics module! We obviously need tests and you need to run pre-commit run --all-files but this is exactly what I was looking for in a first PR for this.
Can you also add a slightly more elaborate PR description and reference the corresponding github issue #384 ?
nina-msft
reviewed
Jul 16, 2025
nina-msft
reviewed
Jul 16, 2025
romanlutz
reviewed
Jul 21, 2025
nina-msft
reviewed
Jul 21, 2025
nina-msft
reviewed
Jul 21, 2025
nina-msft
reviewed
Jul 21, 2025
romanlutz
approved these changes
Jul 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analyzes the attack results.
related to #384