FEAT: Add binary_path data type#1315
Merged
jsong468 merged 7 commits intomicrosoft:mainfrom Jan 15, 2026
Merged
Conversation
romanlutz
reviewed
Jan 14, 2026
romanlutz
reviewed
Jan 14, 2026
Contributor
|
"content is no longer passed as an arg to value in data_serializer_factory. This was misleading since value should be a file path and was overriden in save_data method call in the next line anyways." |
Contributor
Author
Line 412 of pdf_converter.py :) @hannahwestra25 |
hannahwestra25
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
binary_pathdata type to represent arbitrary binary data stored in blob or disk storage, particularly useful for XPIA attacks where targets may not support specific file types.binary_pathtoPromptDataTypeLiteral inliterals.pyBlobPathDataTypeSerializerclass indata_type_serializer.pywheredata_on_disk()=True, uses/binariessubdirectory, default extension.bindata_serializer_factoryto routebinary_pathto the new serializerPDFConverterto outputbinary_pathinstead ofurlwhich was semantically incorrect.Minor change:
contentis no longer passed as an arg tovalueindata_serializer_factoryin PDF converter. This was misleading sincevalueshould be a file path and was overriden insave_datamethod call in the next line anyways.Tests and Documentation
Tests added/updated:
test_data_type_serializer.py:test_literals.pyto includebinary_pathin expected literalstest_pdf_converter.pyto expectbinary_pathoutput type instead ofurltest_prompt_converter.pyto ensure correctexpected_output_typeNotebook:
5_file_converters.ipynbnotebook