MAINT Enable ruff TCH (flake8-type-checking) rules and fix all violations#1395
Merged
romanlutz merged 12 commits intomicrosoft:mainfrom Feb 26, 2026
Merged
MAINT Enable ruff TCH (flake8-type-checking) rules and fix all violations#1395romanlutz merged 12 commits intomicrosoft:mainfrom
romanlutz merged 12 commits intomicrosoft:mainfrom
Conversation
romanlutz
commented
Feb 23, 2026
Move type-only imports into TYPE_CHECKING blocks to improve runtime performance: - Move first-party imports used only in annotations (TC001) - Move third-party imports used only in annotations (TC002) - Move stdlib imports used only in annotations (TC003) - Fix string union in runtime annotation with __future__ annotations (TC010) - Ignore TC006 (quoting cast types is unnecessary for builtins) - Clean up resulting isort and unused import issues Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
romanlutz
force-pushed
the
romanlutz/ruff_tch
branch
from
4a85ca9 to
3ca0f70
Compare
Resolve conflicts from main branch updates including: - ComponentIdentifier refactor (replacing individual identifier types) - New lint rules (W) in pyproject.toml - Various code changes in scorer, converter, and executor modules
Resolved pyproject.toml (keep both RET and TCH), accepted main for remote_dataset_loader.py and hugging_face_chat_target.py then re-applied TCH fixes. Added noqa for scorer.py runtime cast imports. Ignore TCH in doc/ since notebooks run at runtime. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The chatml_tokenizer_normalizer fixture was calling AutoTokenizer.from_pretrained() which requires network access to HuggingFace. Replaced with a mock that simulates ChatML template formatting, making the test fully offline. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…to TYPE_CHECKING - scorer.py: Move PromptChatTarget/PromptTarget to TYPE_CHECKING block (only used in annotations, file has 'from __future__ import annotations') - workflow_strategy.py + 4 other files: Move 'import logging' back to runtime with noqa:TC003 (stdlib module, no import cost concern) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move type-only imports into TYPE_CHECKING blocks to improve runtime performance: