Skip to content

Fix multiline JSON extraction in exceptions helpers #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rlundeen2 merged 2 commits into from
Mar 16, 2026
Merged

Fix multiline JSON extraction in exceptions helpers #1474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a67ed07
fix multiline JSON extraction in exceptions helpers
biefan Mar 16, 2026
9f77953
Potential fix for pull request finding
rlundeen2 Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions pyrit/exceptions/exceptions_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,16 @@ def extract_json_from_string(response_msg: str) -> str:
str: The extracted JSON string if found, otherwise the original string.

"""
json_pattern = re.compile(r"\{.*\}|\[.*\]")
match = json_pattern.search(response_msg)
if match:
return match.group(0)
decoder = json.JSONDecoder()
for index, char in enumerate(response_msg):
if char not in "[{":
continue

try:
_, end_index = decoder.raw_decode(response_msg, idx=index)
return response_msg[index:end_index]
except json.JSONDecodeError:
continue

return response_msg

Expand Down
4 changes: 4 additions & 0 deletions tests/unit/exceptions/test_exceptions_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ def test_remove_end_md_json(input_str, expected_output):
("No JSON here", "No JSON here"),
('jsn\n{"key": "value"}\n```', '{"key": "value"}'),
('Some text before JSON {"a": [1,2,3], "b": {"c": 4}} some text after JSON', '{"a": [1,2,3], "b": {"c": 4}}'),
(
'Some text before JSON {\n "key": "value",\n "nested": {"enabled": true}\n} some text after JSON',
'{\n "key": "value",\n "nested": {"enabled": true}\n}',
),
],
)
def test_extract_json_from_string(input_str, expected_output):
Expand Down
Loading