MAINT Normalize remote dataset file types from URLs#1486
Merged
romanlutz merged 3 commits intomicrosoft:mainfrom Apr 15, 2026
Merged
MAINT Normalize remote dataset file types from URLs#1486romanlutz merged 3 commits intomicrosoft:mainfrom
romanlutz merged 3 commits intomicrosoft:mainfrom
Conversation
romanlutz
approved these changes
Mar 17, 2026
Contributor
|
This needs fixes to pre-commit steps |
romanlutz
changed the title
…commit issues - Resolve merge conflict in test_remote_dataset_loader.py (keep both new tests) - Add missing Returns section to _get_file_type docstring (ruff DOC201) - Fix missing newline at end of test file (end-of-file-fixer) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Cover query strings, fragments, uppercase extensions, local paths, and no-extension edge case. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
_RemoteDatasetLoader._fetch_from_url()currently infers the file type withsource.split(".")[-1]. That breaks two real input shapes:https://example.com/data.json?download=1https://example.com/data.JSONBoth are currently rejected with
Invalid file_typebefore the loader even reaches the HTTP fetch path, even though the underlying data format is valid and supported.Testing
.venv/bin/pytest tests/unit/datasets/test_remote_dataset_loader.py -q