Support CRLF raw HTTP requests in HTTPTarget#1491
Merged
romanlutz merged 1 commit intomicrosoft:mainfrom Mar 18, 2026
Merged
Conversation
romanlutz
approved these changes
Mar 18, 2026
riyosha
pushed a commit
to riyosha/PyRIT
that referenced
this pull request
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HTTPTarget.parse_raw_http_request()Problem
HTTPTarget.parse_raw_http_request()currently splits raw requests on"\n\n"and header lines on"\n".That works for LF-only input, but raw HTTP requests copied from tools commonly use CRLF line endings. With CRLF input, the current parser fails to split headers and body correctly and leaves carriage returns embedded in header lines.
In practice, valid raw HTTP requests can fail to parse even though the content is otherwise correct.
Testing
.venv/bin/pytest tests/unit/target/test_http_target_parsing.py -q