FIX Preserve silent when loading config overrides#1500
Merged
romanlutz merged 1 commit intomicrosoft:mainfrom Mar 19, 2026
Merged
FIX Preserve silent when loading config overrides#1500romanlutz merged 1 commit intomicrosoft:mainfrom
romanlutz merged 1 commit intomicrosoft:mainfrom
Conversation
romanlutz
approved these changes
Mar 18, 2026
romanlutz
changed the title
riyosha
pushed a commit
to riyosha/PyRIT
that referenced
this pull request
Mar 24, 2026
jbolor21
pushed a commit
to jbolor21/jbolor-PyRIT
that referenced
this pull request
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
silentflag whenConfigurationLoader.load_with_overrides()reads default or explicit config filessilent: truevaluesProblem
ConfigurationLoader.load_with_overrides()mergesmemory_db_type,initializers,initialization_scripts, andenv_filesfrom configuration files, but it drops thesilentfield entirely.As a result, config files that set
silent: trueare loaded withsilent=False, so initialization output is not suppressed even though the configuration explicitly requests it.Testing
.venv/bin/pytest tests/unit/setup/test_configuration_loader.py -q