FIX Reject explicit empty objectives in batch scoring#1503
Merged
romanlutz merged 2 commits intomicrosoft:mainfrom Apr 24, 2026
Merged
FIX Reject explicit empty objectives in batch scoring#1503romanlutz merged 2 commits intomicrosoft:mainfrom
romanlutz merged 2 commits intomicrosoft:mainfrom
Conversation
jbolor21
approved these changes
Apr 22, 2026
- Update Raises docstring in score_prompts_batch_async to reflect the actual validation logic (length mismatch, not 'is empty') - Add regression test confirming objectives=None defaults to empty strings in score_prompts_batch_async - Add regression test confirming objectives=None omits objectives from the batch call in score_image_batch_async Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
romanlutz
approved these changes
Apr 24, 2026
romanlutz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
objectivesfrom an explicit empty sequence in batch scoring entry pointsobjectives=[]when scoring non-empty prompt or image batchesProblem
score_prompts_batch_async()treatsobjectives=[]the same asobjectives=None, replacing it with default empty-string objectives and continuing into the scoring pipeline.score_image_batch_async()has the same issue. This skips the documented length validation and can trigger unrelated downstream failures instead of failing fast.Validation
.venv/bin/pytest tests/unit/score -q.venv/bin/ruff check pyrit/score/scorer.py tests/unit/score/test_scorer.py