FIX GUI promote conversation to main feature working#1513
Merged
adrian-gavrila merged 1 commit intomicrosoft:mainfrom Mar 18, 2026
Merged
FIX GUI promote conversation to main feature working#1513adrian-gavrila merged 1 commit intomicrosoft:mainfrom
adrian-gavrila merged 1 commit intomicrosoft:mainfrom
Conversation
- Fix URL mismatch: frontend called /change-main-conversation but backend expects /update-main-conversation - Add panel refresh after successful promote so star icons update immediately - Replace boolean locked prop with lockedReason string for contextual disabled tooltips explaining why actions are unavailable - Update E2E tests to click the star button instead of calling the backend API directly, ensuring the full UI flow is tested Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
riyosha
pushed a commit
to riyosha/PyRIT
that referenced
this pull request
Mar 24, 2026
Co-authored-by: Adrian Gavrila <agavrila@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jbolor21
pushed a commit
to jbolor21/jbolor-PyRIT
that referenced
this pull request
Mar 25, 2026
Co-authored-by: Adrian Gavrila <agavrila@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The star button in the Conversation Panel (used to promote a conversation to "main") was non-functional due to three compounding issues:
/attacks/{id}/change-main-conversationbut the backend route is/attacks/{id}/update-main-conversation. The API call silently 404'd and the error was swallowed by the catch block.navigating away and back.
Changes
frontend/src/services/api.ts— Fix endpoint URL fromchange-main-conversationtoupdate-main-conversationfrontend/src/components/Chat/ChatWindow.tsx— AddsetPanelRefreshKeyafter successful promote; replace booleanlockedprop with
lockedReasonstring carrying contextual messagesfrontend/src/components/Chat/ConversationPanel.tsx— Update prop interface and tooltips to display specific lock reasonsfrontend/e2e/flows.spec.ts— Update two seeded E2E tests to click the star button via UI instead of calling the backend APIdirectly (removing workaround for the URL mismatch)
Tests and Documentation
npx jest)flows.spec.ts: "should change main conversation" and "full lifecycle" now test the full UI click → API →refresh flow instead of bypassing the frontend with direct API calls
reason for each disabled state