FIX: resolve npm path in prepare_package.py on Windows#1629
Merged
adrian-gavrila merged 1 commit intomicrosoft:mainfrom Apr 17, 2026
Merged
Conversation
On Windows, subprocess.run([ pm, ...]) fails with FileNotFoundError because npm is actually npm.cmd. The resolved npm path from shutil.which( pm) is already stored in the pm variable above — use it consistently. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hannahwestra25
approved these changes
Apr 17, 2026
adrian-gavrila
added a commit
that referenced
this pull request
Apr 17, 2026
Co-authored-by: Adrian Gavrila <agavrila@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Discovered bug in build script while running step 6 (
python build_scripts/prepare_package.py) of the v0.13.0 release process on Windows.Tests and Documentation
Re-ran
python build_scripts/prepare_package.pyon Windows end-to-end after the fix — frontend dependencies install and the frontend bundle builds successfully.