FEAT: Deprecate use_entra_auth and add auto-detect auth for Azure Speech converters#1634
Merged
Conversation
jsong468
reviewed
Apr 21, 2026
jsong468
reviewed
Apr 21, 2026
jsong468
reviewed
Apr 21, 2026
jsong468
reviewed
Apr 21, 2026
jsong468
reviewed
Apr 21, 2026
jsong468
reviewed
Apr 21, 2026
jsong468
reviewed
Apr 21, 2026
jsong468
reviewed
Apr 21, 2026
jsong468
reviewed
Apr 21, 2026
romanlutz
reviewed
Apr 21, 2026
jsong468
reviewed
Apr 21, 2026
jsong468
reviewed
Apr 21, 2026
jsong468
reviewed
Apr 22, 2026
jsong468
approved these changes
Apr 22, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…scorer deprecation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
8a66c90 to
c971505
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deprecates the
use_entra_authparameter across both Azure Speech converters and the scorer pass-through chain, replacing it with auto-detection logic that matches the OpenAI target pattern.Auth is now resolved automatically:
azure_speech_key(orAZURE_SPEECH_KEYenv var) -> API key authazure_speech_key(sync or async token provider) -> Entra token auth viaaad#{resource_id}#{token}formatDefaultAzureCredential+azure_speech_resource_idThe deprecated
use_entra_authparam is kept with aDeprecationWarning(removal target: v0.15.0) for backward compatibility.Note: Both converters now enforce keyword-only args (
*) per style guide. All existing callers already use keyword args, but this is technically a breaking change for positional usage. Also,azure_speech_keyis no longer visible in the backend converter catalog since its type changed fromOptional[str]toUnion[str, Callable, None]- users configure the key via theAZURE_SPEECH_KEYenv var in the backend.Files changed:
azure_speech_text_to_audio_converter.py- primary targetazure_speech_audio_to_text_converter.py- identical auth logicaudio_transcript_scorer.py,audio_true_false_scorer.py,audio_float_scale_scorer.py- deprecate pass-through param.env_example- updated commentTests and Documentation
doc/code/converters/2_audio_converters.py/.ipynb) don't useuse_entra_auth- no JupyText changes needed