FEAT Add AzureMLChatTarget support to GUI#1681
Merged
romanlutz merged 8 commits intoMay 4, 2026
Merged
Conversation
Contributor
|
@blakebullwinkel this is failing the test coverage threshold. LMK if you need assistance for this 🙂 |
- Add test for AzureML custom params (exercises onChange handlers) - Add test for dialog close via onOpenChange - Consolidate duplicated target type lists into single TARGET_TYPE_CONFIG - Use @/ import alias per frontend style guide Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The deployment-vs-model distinction applies to any target, not just OpenAI. Move the underlying model switch out of the isOpenAI conditional so it renders for AzureML and any future target types too. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
romanlutz
approved these changes
May 4, 2026
Contributor
romanlutz
left a comment
romanlutz
left a comment
There was a problem hiding this comment.
There are a few cases where it's now if azureml ... else (openai) ... but that will get cleaned up automatically when we add more targets because we can cleanly refactor this to have per-type components. I'm not worried about it with just 2 options.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
super().__init__() needs CentralMemory before the token check runs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
AzureMLChatTargetas a supported target type in the GUI. When selected, the form shows AML-specific params (max new tokens, temperature, top-p, repetition penalty) instead of OpenAI params.No backend changes needed,
TargetServicealready discovers allPromptTargetsubclasses dynamically.Tests and Documentation
Added two unit tests to CreateTargetDialog.test.tsx:
All 14 tests in the file pass. No doc changes needed, this is a GUI-only feature.