MAINT unify how default adversarial and scorer targets are set in scenarios#1695
Merged
Conversation
added 3 commits
May 6, 2026 15:17
behnam-o
changed the title
rlundeen2
reviewed
May 7, 2026
rlundeen2
reviewed
May 7, 2026
rlundeen2
reviewed
May 7, 2026
rlundeen2
reviewed
May 7, 2026
rlundeen2
reviewed
May 7, 2026
behnam-o
changed the title
hannahwestra25
approved these changes
May 8, 2026
jsong468
reviewed
May 8, 2026
jsong468
reviewed
May 8, 2026
jsong468
reviewed
May 8, 2026
jsong468
reviewed
May 8, 2026
jsong468
reviewed
May 8, 2026
jsong468
reviewed
May 8, 2026
romanlutz
reviewed
May 8, 2026
romanlutz
reviewed
May 8, 2026
…into scenario-targets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
1- Use a common logic for resolving default adversarial and scorer targets in scenarios
2- Have a fallback mechanism that uses the target identified by OPENAI_CHAT_*** env variables. This allows someone to only define 1 endpoint and get a runnable scenario