Skip to content

[FEAT]: GUI: Adding Entra Auth Option to New Targets#1762

Merged
jbolor21 merged 15 commits into
microsoft:mainfrom
jbolor21:bjagdagdorj/gui_entra_auth
May 29, 2026
Merged

[FEAT]: GUI: Adding Entra Auth Option to New Targets#1762
jbolor21 merged 15 commits into
microsoft:mainfrom
jbolor21:bjagdagdorj/gui_entra_auth

Conversation

@jbolor21
Copy link
Copy Markdown
Contributor

@jbolor21 jbolor21 commented May 19, 2026

Description

Adding option for new targets to use entra auth instead of API key only.

Screenshots:
(new auth option):
image

(new test target added successfully!)
image

(user validation for non-azure endpoints)
image

Tests and Documentation

Ran existing tests, added new ones (todo)

@jbolor21 jbolor21 marked this pull request as draft May 19, 2026 21:42
@jbolor21 jbolor21 marked this pull request as ready for review May 20, 2026 20:15
@jbolor21 jbolor21 changed the title [DRAFT] [FEAT]: GUI: Adding Entra Auth Option to New Targets [FEAT]: GUI: Adding Entra Auth Option to New Targets May 20, 2026
Copy link
Copy Markdown
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work scoping Entra to OpenAI and AzureML targets explicitly. A few things — most importantly a token-leak risk on the AzureML branch, plus the frontend currently assumes every entry in TARGET_TYPE_CONFIG is Entra-capable, which won't hold as we add more target types.

Comment thread pyrit/backend/services/target_service.py
Comment thread frontend/src/components/Config/CreateTargetDialog.tsx Outdated
Comment thread frontend/src/components/Config/CreateTargetDialog.tsx Outdated
Comment thread pyrit/backend/models/targets.py Outdated
Comment thread pyrit/backend/services/target_service.py
Comment thread frontend/src/components/Config/CreateTargetDialog.tsx Outdated
Comment thread pyrit/prompt_target/azure_ml_chat_target.py Outdated
# Conflicts:
#	pyrit/prompt_target/azure_ml_chat_target.py
@jbolor21 jbolor21 added this pull request to the merge queue May 29, 2026
Merged via the queue into microsoft:main with commit 0573d6e May 29, 2026
48 checks passed
@jbolor21 jbolor21 deleted the bjagdagdorj/gui_entra_auth branch May 29, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants