DOC: Add contributor instructions for dataset loaders#1775
Merged
romanlutz merged 2 commits intoMay 21, 2026
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rlundeen2
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
.github/instructions/datasets.instructions.mdwith the conventions Copilot (and human contributors) should follow when adding or modifying seed dataset loaders underpyrit/datasets/seed_datasets/.Covers the points that recur in dataset PR reviews:
SeedObjectivevsSeedPrompt— picking the right seed type for behavior/goal rows vs literal messages_RemoteDatasetLoaderand using its helpers (_fetch_from_huggingface,_fetch_from_url,_validate_enum/_validate_enums)tokenargument +HUGGINGFACE_TOKENenv fallback, docstring requirements_parse_metadataValueErroron empty filter resultsremote/__init__.py(imports +__all__)doc/references.bib+ the hidden-citations block indoc/bibliography.md)_fetch_from_huggingface, asyncio-auto, token forwarding)Modeled on the structure, depth, and frontmatter style of
converters.instructions.md,scenarios.instructions.md, andoutput.instructions.md. Does not duplicate rules already instyle-guide.instructions.md(async suffix, kw-only, type hints, enums-over-Literals).Tests and Documentation
Markdown-only contributor-instructions change — no code, tests, or notebooks affected.