FIX: bump transitive ws to 8.21.0 to address GHSA-58qx-3vcg-4xpx#1873
Merged
Conversation
The frontend lockfile pulled in ws@8.19.0 transitively via jest-environment-jsdom -> jsdom@20.0.3, which is vulnerable to uninitialized memory disclosure in WebSocket.close() when a TypedArray is passed as the reason argument (GHSA-58qx-3vcg-4xpx / CVE-2026-45736, medium severity, fixed in 8.20.1). GitHub auto-dismissed alert microsoft#170 because the dependency is transitive and dev-only, but the vulnerable version was still resolved in package-lock.json. Add ws to the existing `overrides` block and pin it to 8.21.0 (the latest 8.x, satisfying jsdom's ws@^8.11.0 range). Verified locally: npm install resolves ws@8.21.0 (overridden); type-check, lint, and the full jest suite all pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rlundeen2
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frontend lockfile pulled in
ws@8.19.0transitively viajest-environment-jsdom -> jsdom@20.0.3, which is vulnerable to uninitialized memory disclosure inWebSocket.close()when aTypedArrayis passed as thereasonargument (GHSA-58qx-3vcg-4xpx / CVE-2026-45736, medium severity, fixed in 8.20.1).GitHub auto-dismissed alert #170 because the dependency is transitive and dev-only, but the vulnerable version was still resolved in
package-lock.json. This PR addswsto the existingoverridesblock infrontend/package.jsonand pins it to8.21.0(the latest 8.x, satisfying jsdom'sws@^8.11.0range).Verification
npm installresolvesws@8.21.0 overridden(confirmed vianpm ls ws).npm run type-checkpasses.npm run lintpasses.package.json(no drift afternpm install).mainmerged in cleanly with no conflicts.