MAINT: Alembic Initialize_pyrit output#1895
Merged
rlundeen2 merged 2 commits intoJun 2, 2026
Merged
Conversation
initialize_pyrit(silent=True) still printed Alembic's 'No new upgrade operations detected.' message because the schema-check ran with the default stdout. Thread the silent flag from initialize_pyrit_async through the memory constructors into the migration helpers, routing Alembic output to an in-memory buffer when silent and to sys.stdout (resolved at call time) otherwise. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Wrap the migration stdout stream so Alembic's own messages (e.g. 'No new upgrade operations detected.') are prefixed and identifiable as Alembic output, disambiguating them from PyRIT/REST API output. Update tests to assert the prefix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
romanlutz
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initialize_pyrit_asynccould produce output from Alembic's migration. This was kind of confusing.This PR adds some context to that so
initialize_pyrit_asyncoutput is more cohesive