MAINT Making Prompt Converters Async#211
Merged
jbolor21 merged 12 commits intoMay 20, 2024
Merged
Conversation
rlundeen2
reviewed
May 16, 2024
rlundeen2
reviewed
May 16, 2024
rlundeen2
reviewed
May 16, 2024
rlundeen2
reviewed
May 16, 2024
rlundeen2
reviewed
May 16, 2024
…dagdorj/asyncConvert merging
rlundeen2
reviewed
May 17, 2024
rlundeen2
reviewed
May 17, 2024
rlundeen2
reviewed
May 17, 2024
Contributor
|
Can you please run all notebooks before merging to make sure nothing is broken? Make sure to not commit the new notebooks where nothing has changed, but we want to make sure there aren't errors :)
|
rlundeen2
approved these changes
May 17, 2024
rlundeen2
left a comment
rlundeen2
left a comment
Contributor
There was a problem hiding this comment.
Looking great! Please ping if you're unsure about any comments or you want more direction/feedback :)
SafwanA02
added a commit
to SafwanA02/PyRIT
that referenced
this pull request
Jun 18, 2024
This reverts commit 5a85020.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Making all prompt converters async and fixing unit tests accordingly
Tests and Documentation
Ran and created new unit tests to test async functionality