Conversation
rdheekonda
approved these changes
Jan 11, 2024
added 7 commits
January 11, 2024 13:57
nina-msft
reviewed
Jan 12, 2024
…sn't do it on own
romanlutz
added a commit
that referenced
this pull request
Jan 18, 2024
Fixed broken link to notebook (#7) * Fixed broken link to notebook in Readme * changed label in notebooks to file names so people can see image filename in case it does not load --------- Co-authored-by: Bolor <bjagdagdorj@microsoft.com>
romanlutz
added a commit
that referenced
this pull request
Jan 26, 2024
Fixed broken link to notebook (#7) * Fixed broken link to notebook in Readme * changed label in notebooks to file names so people can see image filename in case it does not load --------- Co-authored-by: Bolor <bjagdagdorj@microsoft.com>
adrian-gavrila
pushed a commit
to adrian-gavrila/PyRIT
that referenced
this pull request
Apr 24, 2026
Bundled response to the remaining reviewer comments on the Attack History filter-Combobox migration. microsoft#2/microsoft#3 memory: switch `attack_class` and `targeted_harm_categories` deprecations in `MemoryInterface.get_attack_results` to the project-standard `print_deprecation_message(removed_in="0.15.0")` helper; drop the now-unused `import warnings`. No direct successor exists for `targeted_harm_categories`; point users at `labels={"harm_category": [...]}` (labels supports OR-within-key). microsoft#4 memory/backend: make attack-class matching case-insensitive to match converter-class matching. Removed the explicit `case_sensitive=True` override (default is False in every backend); flipped the regression test to assert lower/upper/mixed casing all match. Service + route docs updated. microsoft#5 frontend: refactor `AttackHistory.fetchAttacks` request-params builder from a stack of seven conditional object spreads into a precomputed, explicitly-guarded `params` object for readability. microsoft#6 frontend: rename `attackClasses` field, `attackClassOptions` prop, `attack-class-filter` testid (and all mirrors) to `attackType*` so they track the server-side `attack_types` query param. microsoft#7 backend: rewrite FastAPI `Query` descriptions for `attack_types`, `converter_types`, and `label` to spell out "May be specified multiple times" semantics with concrete `?key=v1&key=v2` examples. microsoft#8 backend: widen `attack_types` / `converter_types` annotations from `Optional[list[str]]` to `Optional[Sequence[str]]` (matches the already-`Sequence`-typed inner label values). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The link to an example notebook in the README is currently not linking to the correct notebook. This PR fixes the underlying link.
This PR adds the filename of the image in the image tag so users can at least see the image name if the image does not render when users load the notebook in github.