Skip to content

Refactor Keithley 2600 driver to use ParameterWithSetpoints for fast sweep#7851

Draft
trlemon wants to merge 17 commits intomicrosoft:mainfrom
trlemon:trlemon/refactor-keithley2600-driver-fastsweep
Draft

Refactor Keithley 2600 driver to use ParameterWithSetpoints for fast sweep#7851
trlemon wants to merge 17 commits intomicrosoft:mainfrom
trlemon:trlemon/refactor-keithley2600-driver-fastsweep

Conversation

@trlemon
Copy link
Contributor

@trlemon trlemon commented Feb 6, 2026

WIP

Background

The doFastSweep method relies on "old" technology from qcodes_loop, and it also returns a Qcodes dataset which may not be desirable for all applications. Instead, it would be better to use ParameterWithSetpoints and return a numpy array.

Summary of Changes

  • Remove dependence on qcodes_loop
  • Use ParameterWithSetpoints with additional parameters for configuration.
  • Return fast sweep data as numpy array instead of qcodes dataset.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 82.05128% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.09%. Comparing base (e174a5c) to head (806fadf).

Files with missing lines Patch % Lines
...odes/instrument_drivers/Keithley/_Keithley_2600.py 82.05% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7851      +/-   ##
==========================================
+ Coverage   59.94%   60.09%   +0.15%     
==========================================
  Files         352      352              
  Lines       31932    31945      +13     
==========================================
+ Hits        19142    19198      +56     
+ Misses      12790    12747      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks promising!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants