-
Notifications
You must be signed in to change notification settings - Fork 347
Visa improvments #7978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Visa improvments #7978
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e038394
Expose visa resource manager and visa address from pyvisa
jenshnielsen 762dfbb
Add visa properties rather than atters
jenshnielsen 52abd06
Deprecate visalib property
jenshnielsen 263d6cb
Read visalib/backend from pyvisa
jenshnielsen b2af129
Add option to construct visa instr from existing resource
jenshnielsen ba8ce29
Add tests for passing resource to visa insttr
jenshnielsen 51793fe
Fix link
jenshnielsen 0a28cf9
Fix docstring
jenshnielsen 40caed6
Simplify driver
jenshnielsen c6e727c
Fix mypy
jenshnielsen 75475d5
Remove overloads
jenshnielsen fee4482
Add resource to visa kwargs
jenshnielsen 75a0160
Add changelog for 7978
jenshnielsen d4dd47f
Bump pyvisa min version
jenshnielsen 3bc214d
Update changelog
jenshnielsen c8b2444
Make visa_handle a property
jenshnielsen 967b8be
Cleanup visa backend logic
jenshnielsen 1c24e33
Cryo test check terminator
jenshnielsen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| A new ``resource`` parameter has been added that accepts an already-opened | ||
| ``pyvisa.resources.MessageBasedResource``, allowing a ``VisaInstrument`` to be | ||
| constructed from an existing PyVISA resource handle. The ``resource`` parameter | ||
| cannot be combined with ``address``, ``visalib`` or ``pyvisa_sim_file``. These arguments | ||
| are only used to construct a new resource. | ||
|
|
||
| The ``resource_manager``, ``visabackend`` and ``visalib`` ``visa_handle`` attributes of | ||
| :class:`.VisaInstrument` have been converted to read-only properties. | ||
|
|
||
| The ``_address`` property is deprecated in favour of ``address``. | ||
| The ``visalib`` property is deprecated in favour of ``visabackend``. | ||
|
|
||
| The method ``set_address`` now takes visalib as an argument. If this | ||
| is not supplied the default visa library will be used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,5 +24,5 @@ devices: | |
|
|
||
|
|
||
| resources: | ||
| GPIB::1::INSTR: | ||
| GPIB0::1::INSTR: | ||
| device: cryomag_tm620 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.