Merged
Conversation
Override snapshot_base in AMI430SwitchHeater to skip updating state, in_persistent_mode, current, heat_time, and cool_time parameters when the switch heater is not enabled. On real hardware these VISA queries can fail when the heater is disabled, causing snapshot warnings. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jenshnielsen
force-pushed
the
ami_snapshot_fix
branch
from
fd9fcc4 to
c93528e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8009 +/- ##
=======================================
Coverage 70.50% 70.50%
=======================================
Files 333 333
Lines 32426 32436 +10
=======================================
+ Hits 22862 22870 +8
- Misses 9564 9566 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jenshnielsen
commented
Apr 7, 2026
src/qcodes/instrument_drivers/american_magnetics/AMI430_visa.py
Outdated
Show resolved
Hide resolved
astafan8
approved these changes
Apr 7, 2026
astafan8
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures the instrument can be snapshoottted without supressing errors. Note that a cleaner approach may be to skip adding the heater module if not enabled. This would however require restarting the driver if / when the module is enabled so I have opted for a simpler solution here.