fix(utils): catch TypeError from inapplicable descriptors in DelegateAttributes#8079
Merged
jenshnielsen merged 1 commit intomicrosoft:mainfrom Apr 29, 2026
Merged
Conversation
…Attributes The descriptor introspection added in microsoft#8039 can find descriptors via the MRO that are not applicable to the current instance (e.g. type.__name__ invoked on a non-type object). This causes a TypeError when Python's inspect module calls getattr(obj, '__name__', None) on DelegateAttributes subclasses like GetLatest. Catch TypeError in the descriptor __get__ call so that inapplicable descriptors fall through to the normal AttributeError path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8079 +/- ##
=======================================
Coverage 70.59% 70.60%
=======================================
Files 333 333
Lines 32494 32497 +3
=======================================
+ Hits 22940 22943 +3
Misses 9554 9554 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
einsmein
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The descriptor introspection added in #8039 can find descriptors via the MRO that are not applicable to the current instance (e.g.
type.__name__invoked on a non-type object). This causes a TypeError when Python's inspect module callsgetattr(obj, '__name__', None)on DelegateAttributes subclasses like GetLatest.Catch TypeError in the descriptor
__get__call so that inapplicable descriptors fall through to the normal AttributeError path.