Skip to content
This repository was archived by the owner on Aug 21, 2024. It is now read-only.

Comments

Task 1.8 V3!#697

Merged
tcNickolas merged 7 commits intomicrosoft:mainfrom
TonyHoldroyd:main
Dec 2, 2021
Merged

Task 1.8 V3!#697
tcNickolas merged 7 commits intomicrosoft:mainfrom
TonyHoldroyd:main

Conversation

@TonyHoldroyd
Copy link
Contributor

Task 1.8 V3! with that null thing but try again

@TonyHoldroyd
Copy link
Contributor Author

Ciao Mariia,
I have had a few draft pull requests which have given strange problems but I finally managed to get just one Task, 1.8, passed the parser checks. I don't want to tempt fate by closing this without you seeing it. It's quite short, but I I have the rest of the tasks ready, say two at a time, when you have had a chance to look at this I'll append and create pull requests for them. Thanks.

@TonyHoldroyd TonyHoldroyd marked this pull request as ready for review November 20, 2021 20:39
Copy link
Contributor

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I added a link from the kata to the new solution, and did a bit of cleanup. I removed the reference to the measurements, since at this point learners are not yet familiar with the concept, and I've heard often that encountering unfamiliar concepts is stressful.
(We'll need to do a bit of work on the BasicGates kata in that vein, actually, since it switches from single-qubit systems and gates to multi-qubit ones without warning, and I got some feedback about that. But that's in the future!)

Thank you! (And apologies for the delay reviewing the PR - I was out last week, and busy with kicking off Q# Advent Calendar this week)

@tcNickolas tcNickolas merged commit 191d5cc into microsoft:main Dec 2, 2021
@TonyHoldroyd
Copy link
Contributor Author

TonyHoldroyd commented Dec 3, 2021 via email

@tcNickolas
Copy link
Contributor

That sounds wonderful, especially the southern Italy part!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants