Merged
Conversation
you-n-g
reviewed
Mar 25, 2025
|
|
||
| #### enable specification | ||
| spec_enabled: bool = True | ||
| # - [ ] rdagent/components/coder/data_science/raw_data_loader/__init__.py: make spec implementation optional |
| out_spec=PythonAgentOut.get_spec(), | ||
| ) | ||
|
|
||
| if DS_RD_SETTING.spec_enabled: |
Contributor
There was a problem hiding this comment.
Why don't we create a function like get_code_spec ?
| code_spec = workspace.file_dict["spec/ensemble.md"] | ||
| else: | ||
| test_code = ( | ||
| Environment(undefined=StrictUndefined) |
Collaborator
Author
There was a problem hiding this comment.
T cannot render ".txt" file now.
you-n-g
reviewed
Mar 25, 2025
| if DS_RD_SETTING.spec_enabled | ||
| else T("scenarios.data_science.share:component_spec.general").r( | ||
| spec=T("scenarios.data_science.share:component_spec.Model").r(), | ||
| test_code=(DIRNAME / "eval_tests" / "model_test.txt").read_text().replace("model01", target_task.name), |
Contributor
There was a problem hiding this comment.
Why don't we use jinjia to render?
Collaborator
Author
There was a problem hiding this comment.
use jinjia needs more codes
| @@ -1,3 +1,6 @@ | |||
| """ | |||
| Tests for `model_workflow` in model01.py | |||
| if component_info: | ||
| if DS_RD_SETTING.spec_enabled: | ||
| task_spec = sota_exp.experiment_workspace.file_dict[component_info["spec_file"]] | ||
| else: |
Contributor
There was a problem hiding this comment.
Why don't we use test here?
Collaborator
Author
There was a problem hiding this comment.
Here is not for generating codes, just for generating task/component
Jensen246
pushed a commit
to Jensen246/RD-Agent
that referenced
this pull request
Jun 6, 2025
* feat: Add spec_enabled configuration for data science settings * make spec alternative * change spec logic in exp_gen * remove some general texts * align --------- Co-authored-by: Young <afe.young@gmail.com> Co-authored-by: yuanteli <1957922024@qq.com>
licong01-cloud
pushed a commit
to licong01-cloud/RD-Agent
that referenced
this pull request
Dec 13, 2025
* feat: Add spec_enabled configuration for data science settings * make spec alternative * change spec logic in exp_gen * remove some general texts * align --------- Co-authored-by: Young <afe.young@gmail.com> Co-authored-by: yuanteli <1957922024@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots of Test Results (if appropriate):
Types of changes
📚 Documentation preview 📚: https://RDAgent--719.org.readthedocs.build/en/719/