Skip to content

Add support for French decade with century#3153

Merged
tellarin merged 9 commits into
masterfrom
v-michwang/FrenchDateRangeIssue
Sep 4, 2024
Merged

Add support for French decade with century#3153
tellarin merged 9 commits into
masterfrom
v-michwang/FrenchDateRangeIssue

Conversation

@MichaelMWW
Copy link
Copy Markdown
Collaborator

Add support for recognizing French decade with century. It now supports Arabic numbers and language specific number words, examples as below.

  1. dans les années 90
  2. les années quatre-vingt-dix

Copy link
Copy Markdown
Collaborator

@tellarin tellarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to always add (or remove the "NotSupportted" attribute) samples for the cases directly affected by the PR to the corresponding DateTimeModel.json. This will ensure the final output is indeed correct and in the correct format.

Comment thread .NET/Microsoft.Recognizers.Definitions.Common/French/DateTimeDefinitions.cs Outdated
Comment thread .NET/Microsoft.Recognizers.Definitions.Common/French/DateTimeDefinitions.cs Outdated
@MichaelMWW
Copy link
Copy Markdown
Collaborator Author

Don't forget to always add (or remove the "NotSupportted" attribute) samples for the cases directly affected by the PR to the corresponding DateTimeModel.json. This will ensure the final output is indeed correct and in the correct format.

OK.

@MichaelMWW MichaelMWW requested a review from tellarin September 3, 2024 04:24
Copy link
Copy Markdown
Contributor

@aurghob aurghob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tellarin tellarin merged commit cb8f16d into master Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants