Cherry pick commits for new changes#3170
Merged
Merged
Conversation
…ry and number with unit in Spanish (#3154) * Date range without accents - Draft commit * Date range without accents - Fix cannot recognize Spanish written in the 90s * Date range without accents - Revert local nuget config and program.cs change * DateRangeWithoutAccents - Resolved comments --------- Co-authored-by: Michael Wang (Centific Technologies Inc) <v-michwang@microsoft.com>
Bumps [NuGet.CommandLine](https://github.com/NuGet/NuGet.Client) from 5.9.3 to 5.11.5. - [Release notes](https://github.com/NuGet/NuGet.Client/releases) - [Commits](https://github.com/NuGet/NuGet.Client/commits) --- updated-dependencies: - dependency-name: NuGet.CommandLine dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Datetime for longer span - local draft commit * DateTimeForLongerSpan - Implement for from --------- Co-authored-by: Michael Wang (Centific Technologies Inc) <v-michwang@microsoft.com>
bidisha-c
approved these changes
Oct 1, 2024
Member
bidisha-c
left a comment
bidisha-c
left a comment
There was a problem hiding this comment.
I have added one comment which can be addressed in the next iteration.
| } | ||
|
|
||
| // For cases like "for 1 week from today", "for 3 days from 20th May" etc.. | ||
| if (EnglishDatePeriodExtractorConfiguration.ForPrefixRegex != null) |
Member
There was a problem hiding this comment.
do we want to have the english specific rules in the BaseDatePeriodExtractor or should this be in the subclass that handles English rules?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were 3 commits that were not merged in.
Preparing release of 1.8.9 by adding 3 more commits as part of this change.