Merged
Conversation
* Removed ruleinput * Simplified compiled params code * clean up and renaming * Fixed caching and made test cases more specific * updated settings * updated nuget and fix warnings * Added test case for invalid input name * changed input from object to dictionary * Added action related fields and added expression output action * Added evaluateRuleAction and added basic tests for actions * made action names and context case insensitive * Added exception handling * fixed exception message for parsing error * improved constructor for action factory * Added build trigger for pr to develop * Added more testcases for actions * Shared same instance of parser for RulesEngine and OutputExpression action * fixed review comments * Added null check for actions not mentioned in json
…63) * Added support for actions * Renamed ExecuteRule to ExecuteAllRulesAsync
abbasc52
commented
Nov 14, 2020
dishantmunjal
approved these changes
Nov 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.