Skip to content

[codex] Fix GitHub Pages deployment workflow#47

Merged
atulkhare4096 merged 2 commits intomicrosoft:mainfrom
JonusNattapong:fix/github-pages-deploy
Mar 27, 2026
Merged

[codex] Fix GitHub Pages deployment workflow#47
atulkhare4096 merged 2 commits intomicrosoft:mainfrom
JonusNattapong:fix/github-pages-deploy

Conversation

@JonusNattapong
Copy link
Copy Markdown
Contributor

What changed

  • removed the duplicate GitHub Pages workflow
  • added the GitHub Pages configure step
  • updated the README deployment note to reference main

Why

Two Pages workflows were configured for the same branch, which could lead to conflicting or failed GitHub Pages deployments.

Validation

  • validated the workflow YAML locally
  • confirmed cargo xtask deploy builds all 7 books successfully once mdbook and mdbook-mermaid are installed

@JonusNattapong
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@JonusNattapong JonusNattapong marked this pull request as ready for review March 27, 2026 02:47
Copilot AI review requested due to automatic review settings March 27, 2026 02:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes GitHub Pages deployments by consolidating to a single workflow for the main branch and aligning documentation accordingly, reducing the chance of conflicting deployments.

Changes:

  • Removes the duplicate GitHub Pages deployment workflow (deploy.yml).
  • Adds the GitHub Pages configuration step to the remaining Pages workflow.
  • Updates README deployment notes to reference main instead of master.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
README.md Updates deployment note to match main branch and the active Pages workflow.
.github/workflows/pages.yml Adds actions/configure-pages@v5 and adjusts mdbook install commands for the Pages pipeline.
.github/workflows/deploy.yml Removes redundant Pages workflow to avoid conflicting deployments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/pages.yml Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@atulkhare4096 atulkhare4096 merged commit cd88bdf into microsoft:main Mar 27, 2026
1 check passed
@JonusNattapong JonusNattapong deleted the fix/github-pages-deploy branch March 28, 2026 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants