Skip to content
This repository was archived by the owner on Aug 4, 2022. It is now read-only.

Allow user to choose a subset of steps to run#102

Merged
Omaaarz merged 5 commits intomicrosoft:mainfrom
Antonstockmarr:MultiSelectMenu
Oct 18, 2021
Merged

Allow user to choose a subset of steps to run#102
Omaaarz merged 5 commits intomicrosoft:mainfrom
Antonstockmarr:MultiSelectMenu

Conversation

@Antonstockmarr
Copy link
Copy Markdown
Contributor

@Antonstockmarr Antonstockmarr commented Oct 1, 2021

Create two different types of screens, the single select and the multi select used for selecting steps.
Tests included for the two screen types.
#minor
Resolves #75

Create two different types of screens, the single select and the multi select used for selecting steps.
Tests included for the two screen types.
#patch
Resolves microsoft#75
Copy link
Copy Markdown
Contributor

@AndreasHassing AndreasHassing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving for @Omaaarz to approve this, just added a few comments.

Comment thread src/CLIFramework/MultiSelectScreen.cs Outdated
Comment thread src/CLI/EnableScaleUnitFeature.cs
@AndreasHassing AndreasHassing requested a review from Omaaarz October 1, 2021 12:27
The user can specify a range of options as input to multiSelectMenu, e.g. "1-5" or "1 - 4, 6".
Steps are renamed to options in the multiSelectScreen, since the screen operates on options and not necessarily steps.
Comment thread src/CLIFramework/MultiSelectScreen.cs Outdated
Comment thread src/CLI/EnableScaleUnitFeature.cs
@AndreasHassing
Copy link
Copy Markdown
Contributor

I'd say this is a feature add, so am changing #patch to #minor.

@Omaaarz Omaaarz merged commit 9ab08c7 into microsoft:main Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to run individual steps or a subset of steps during scale unit configuration

3 participants