Skip to content
This repository was archived by the owner on Aug 4, 2022. It is now read-only.

Enable single execution deployment#103

Merged
Omaaarz merged 6 commits intomicrosoft:mainfrom
Antonstockmarr:CLIDeploy
Oct 19, 2021
Merged

Enable single execution deployment#103
Omaaarz merged 6 commits intomicrosoft:mainfrom
Antonstockmarr:CLIDeploy

Conversation

@Antonstockmarr
Copy link
Copy Markdown
Contributor

Allows the user to run the tool with argument "--deploy", which runs all steps required for setting up hub and spoke. Also allows "--clean-storage", which will clean all Azure storage accounts. If no arguments are given, the program will run as usual.

Allows the user to run the tool with argument "--deploy", which runs all steps required for setting up hub and spoke. Also allows "--clean-storage", which will clean all Azure storage accounts.
Deployment only works in single one box. Adds error handling to ensure this.
Comment thread src/CLI/ArgumentParser.cs Outdated
Comment thread src/CLI/ArgumentParser.cs Outdated
Comment thread src/CLI/Deployer.cs Outdated
Comment thread src/CLI/Program.cs Outdated
Copy link
Copy Markdown
Contributor

@Omaaarz Omaaarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

Initialize hub first and other scale units after.
Comment thread src/CLI/Deployer.cs Outdated
@Omaaarz
Copy link
Copy Markdown
Contributor

Omaaarz commented Oct 18, 2021

Can we write simple tests for the parser?

Unit testing of the ArgumentParser. Removing redundant Comparison.
Copy link
Copy Markdown
Contributor

@Omaaarz Omaaarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Omaaarz Omaaarz merged commit 6229f07 into microsoft:main Oct 19, 2021
@Antonstockmarr Antonstockmarr deleted the CLIDeploy branch October 19, 2021 08:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants