This repository was archived by the owner on Aug 4, 2022. It is now read-only.
Improve error handling from AOS requests#110
Merged
Omaaarz merged 7 commits intomicrosoft:mainfrom Nov 22, 2021
Merged
Conversation
ReliableRun class will catch AOS exceptions and try to suggest changes. Other errors pass through. If a suggestion is found, or it does not make sense to retry, the request is not repeated. Every AOS error is shown to the user. resolves microsoft#105 #patch
AndreasHassing
suggested changes
Oct 26, 2021
Contributor
Author
|
Hmm, Im not 100% happy with this name either, but it's a tricky one. |
AndreasHassing
approved these changes
Nov 3, 2021
AndreasHassing
suggested changes
Nov 5, 2021
Timeout errors and similar will be caught by reliableRun
Contributor
|
@Antonstockmarr this PR is ready except that it needs to uptake |
AndreasHassing
requested review from
Omaaarz
and removed request for
AndreasHassing
AndreasHassing
approved these changes
Nov 18, 2021
Omaaarz
approved these changes
Nov 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReliableRun class will catch AOS exceptions and try to suggest changes. Other errors pass through. If a suggestion is found, or it does not make sense to retry, the request is not repeated. Every AOS error is shown to the user.
Example of an error with an inline TSG:
resolves #105
#patch