This repository was archived by the owner on Aug 4, 2022. It is now read-only.
Delete and truncate problematic tables #patch#115
Merged
Omaaarz merged 8 commits intomicrosoft:mainfrom Nov 12, 2021
Merged
Conversation
Problematic tables will be cleared on the spoke just before the sys workload is installed instead of doing it as part of initialization. Clearing is only done before SYS, and only if SYS is not already running.
AndreasHassing
suggested changes
Nov 5, 2021
AndreasHassing
suggested changes
Nov 5, 2021
AndreasHassing
approved these changes
Nov 9, 2021
Omaaarz
suggested changes
Nov 9, 2021
Omaaarz
reviewed
Nov 9, 2021
Omaaarz
approved these changes
Nov 12, 2021
Contributor
Author
|
Tested using the single execution deploy option, everything works as expected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The step to "truncate potentially problematic tables" left out tables that might cause issues. Only the NumberSequenceReference tables was truncated. NumberSequenceScope and NumberSequenceTable had rows that were related, but they were not deleted.
The step to remove problematic tables is now part of scale Unit Installation. This means that NumberSequence records can no longer be created between initializing the environment and installing workloads, which could cause the SYS package to fail.
This has been tested by running full deployment on SingleOnebox.
Resolves #113