Skip to content
This repository was archived by the owner on Aug 4, 2022. It is now read-only.

Set the blob name in sas uri#117

Merged
AndreasHassing merged 2 commits intomicrosoft:mainfrom
Antonstockmarr:FixImportWorkloads
Nov 11, 2021
Merged

Set the blob name in sas uri#117
AndreasHassing merged 2 commits intomicrosoft:mainfrom
Antonstockmarr:FixImportWorkloads

Conversation

@Antonstockmarr
Copy link
Copy Markdown
Contributor

When the sas uri is created for the container the blob name is not specified. By setting the blob name, the sas uri can still be used to copy the blob.

#patch
resolves #116

When the sas uri is created for the container the blob name is not specified. By setting the blob name, the sas uri can still be used to copy the blob.
@Antonstockmarr
Copy link
Copy Markdown
Contributor Author

Tested by creating a SAS url from the Azure portal for the container and importing it in the devTools.

@AndreasHassing
Copy link
Copy Markdown
Contributor

Why do we assume the SAS URL is created for the container, and not the blob? I would assume that we should just create a SAS URL directly for the blob?

@Antonstockmarr
Copy link
Copy Markdown
Contributor Author

There is a Geneva Action creating a SAS token for an environment, and the generated token points at the container and not the blob. But if you enter a sas for the blob it would still work.

@AndreasHassing
Copy link
Copy Markdown
Contributor

AndreasHassing commented Nov 9, 2021

There is a Geneva Action creating a SAS token for an environment, and the generated token points at the container and not the blob. But if you enter a sas for the blob it would still work.

Ah, so that's how customers/devs will get the workload instances for now, we pass a read-only SAS URL for the container in the hub's storage account wherein the current.json lives?

@AndreasHassing AndreasHassing merged commit 31fbeff into microsoft:main Nov 11, 2021
@Antonstockmarr Antonstockmarr deleted the FixImportWorkloads branch November 12, 2021 09:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Importing workloads does not work with SAS token created by AX.

3 participants