This repository was archived by the owner on Aug 4, 2022. It is now read-only.
Allow choosing a specific environment to upgrade/drain/start workloads on#121
Merged
Omaaarz merged 3 commits intomicrosoft:mainfrom Nov 23, 2021
Merged
Conversation
Also print progress while upgrading. Tested in single box. #patch
Use multiselect menu to choose environments, while still making it easy to drain/start workloads on all environments.
Omaaarz
approved these changes
Nov 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using the MultiSelectMenu the user can choose a specific environment to perform the action on. This is useful if for example the drain succeeded on hub but not on spoke. Before, retrying would produce an error because the hub was already drained, but now drain can be retried only on the spoke. It is still easy to select all environments just by pressing enter in the menu.
Also, upgrade workloads now prints its progress to the user.