This repository was archived by the owner on Aug 4, 2022. It is now read-only.
Ping AOS whenever an AOSClient is constructed#124
Merged
AndreasHassing merged 3 commits intomicrosoft:mainfrom Jan 10, 2022
Merged
Ping AOS whenever an AOSClient is constructed#124AndreasHassing merged 3 commits intomicrosoft:mainfrom
AndreasHassing merged 3 commits intomicrosoft:mainfrom
Conversation
Make sure that the AOS is warm whenever a new client is created. Improve readability of errors caused by timeout. #patch
Antonstockmarr
changed the title
Omaaarz
reviewed
Nov 25, 2021
Contributor
|
@Antonstockmarr is this good to go - tested and validated? |
Contributor
Author
Yes, tested, validated and ready to go in. This change will make sure that the AOS is responsive before making any requests, and if the connection times out, the error will say so explicitly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that the AOS is warm whenever a new client is created. Improve readability of errors caused by timeout.
#patch
resolves #106