Skip to content
This repository was archived by the owner on Aug 4, 2022. It is now read-only.

Install workload in scale unit even if found Ready #128

Merged
AndreasHassing merged 1 commit into from
Jan 7, 2022
Merged

Install workload in scale unit even if found Ready #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/ScaleUnitManagement/WorkloadSetupOrchestrator/ScaleUnitWorkloadInstaller.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ private async Task InstallWorkloadsOnScaleUnit()

foreach (WorkloadInstance workloadInstance in workloadInstances)
{
if (await WorkloadInstanceManager.IsWorkloadInstanceInReadyState(scaleUnitAosClient, workloadInstance))
Copy link
Copy Markdown
Contributor

@Omaaarz Omaaarz Jan 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess one of the reasons we might have had this reason, is that if in the previous run couple of workloads were installed, we just need to install only the remaining ones.

Not sure if that will cause us problems?

Copy link
Copy Markdown
Contributor Author

@AndreasHassing AndreasHassing Jan 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as a single run of workload installation succeeds, we're fine.

The new behavior will act as a workload upgrade; can that cause problems, you think?

Copy link
Copy Markdown
Contributor

@Omaaarz Omaaarz Jan 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a second thought, it shouldn't be causing problems. At least, this will save us the workarounds we are doing now.

continue;

if (!await WorkloadInstanceManager.IsWorkloadInstanceInInstallingState(scaleUnitAosClient, workloadInstance))
{
Console.WriteLine($"Installing the {workloadInstance.VersionedWorkload.Workload.Name} workload");
Expand Down