This repository was archived by the owner on Aug 4, 2022. It is now read-only.
Make emergency transition independent of the spoke#155
Merged
AndreasHassing merged 5 commits intomainfrom Mar 1, 2022
Merged
Conversation
Improve visibility for the user. Check if there are no EnvironmentOverrides already on the workload.
AndreasHassing
approved these changes
Feb 22, 2022
Contributor
AndreasHassing
left a comment
AndreasHassing
left a comment
There was a problem hiding this comment.
Minor comments, otherwise looks good 😊👍.
src/ScaleUnitManagement/WorkloadSetupOrchestrator/WorkloadMover.cs
Outdated
Show resolved
Hide resolved
src/ScaleUnitManagement/WorkloadSetupOrchestrator/WorkloadMover.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Andreas Bjørn Hassing <andreas@famhassing.dk>
Co-authored-by: Andreas Bjørn Hassing <andreas@famhassing.dk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The emergency transition does no longer depend on the spoke. It gets the workload definitions from the hub, and sees which ones are assigned to the spoke.
Improve visibility for the user, so they can see which workloads are affected, if any.
Check if there are no EnvironmentOverrides already on the workload, since the overrides should not be set multiple times.
Tested on singleOneBox environment.
Closes #149