Skip to content

Vector algorithms cleanups#6089

Merged
StephanTLavavej merged 3 commits intomicrosoft:mainfrom
AlexGuteniev:vector-algorithms-cleanup
Feb 17, 2026
Merged

Vector algorithms cleanups#6089
StephanTLavavej merged 3 commits intomicrosoft:mainfrom
AlexGuteniev:vector-algorithms-cleanup

Conversation

@AlexGuteniev
Copy link
Contributor

Easy cleanups:

  • More constants. (Ideally, make everything constant, except loop counter and loop-carried dependency).
  • _M_IX86 / _M_X64 to _WIN64. That's the last occurrence after Enable ARM64EC vector algorithms #6084.
  • _mm_cvtsi64x_si128 -> _mm_cvtsi64_si128. Standardize spelling.

Standardizing for _mm_cvtsi64_si128 was preferred over the other way around because:

  • We already consistently prefer _mm_cvtsi128_si64 over _mm_cvtsi128_si64x
  • Clang does not understand the si64x form of either
  • The form without x is more common (searched on GitHub and elsewhere)
  • The x character doesn't seem to convey any meaning. Seems that it is supposed to mean that general-purpose 64-bit integer is used, as opposed to __m64 MMX vector, this can be seen in _epi64x ending intrinsics, which have _epi64 counterparts, But this is no longer ever necessary, as no point in using MMX.

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner February 16, 2026 18:58
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Feb 16, 2026
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Feb 17, 2026
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Feb 17, 2026
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Feb 17, 2026
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required.

@StephanTLavavej StephanTLavavej merged commit 8e0c6ff into microsoft:main Feb 17, 2026
45 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Feb 17, 2026
@AlexGuteniev AlexGuteniev deleted the vector-algorithms-cleanup branch February 17, 2026 15:07
@StephanTLavavej
Copy link
Member

Thank you for your ongoing dedication to code quality and consistency! 🪄 😺 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants